Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Horizontal line on login page when no SSO providers are selected #9094

Open
BOHEUS opened this issue Dec 16, 2024 · 4 comments · May be fixed by #9160
Open

Horizontal line on login page when no SSO providers are selected #9094

BOHEUS opened this issue Dec 16, 2024 · 4 comments · May be fixed by #9160

Comments

@BOHEUS
Copy link
Contributor

BOHEUS commented Dec 16, 2024

Scenario:

  1. Open login page

Actual: There's horizontal line despite no SSO providers
Image

Expected: Horizontal line must be visible only if at least 1 SSO provider is selected
@muraliSingh7
Copy link
Contributor

@BOHEUS
The issue appears to be in the SignInUpWorkspaceScopeForm.tsx file.
The logic which needs to be removed is :

{(authProviders.google ||
          authProviders.microsoft ||
          authProviders.sso.length > 0) &&
        authProviders.password ? (
          <HorizontalSeparator visible />
        ) : null}

As each authentication provider has its own HorizontalSeparator, and the password provider is displayed last, it should not have a separator following it.

@FurquanAnwer
Copy link

Can I work on this issue ?

@imjaglan
Copy link

hey @muraliSingh7 i believe it's the SignInUpWorkspaceScopeForm.tsx. component not the SignInUpWorkspaceScopeForm.tsx. that HorizontalSeparator is coming from that component

@muraliSingh7
Copy link
Contributor

hey @muraliSingh7 i believe it's the SignInUpWorkspaceScopeForm.tsx. component not the SignInUpWorkspaceScopeForm.tsx. that HorizontalSeparator is coming from that component

I am also saying about same component.

@muraliSingh7 muraliSingh7 mentioned this issue Dec 18, 2024
Closed
@AMoreaux AMoreaux linked a pull request Dec 20, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
Product development ✅
Status: 🆕 New
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refacto(auth): Simplify workspace lookup and cleanup UI logic twentyhq/twenty
4 participants
@FurquanAnwer @BOHEUS @muraliSingh7 @imjaglan