Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean scroll paddings in Navigation Drawer #9026

Open
ehconitin opened this issue Dec 11, 2024 · 6 comments · May be fixed by #9141
Open

Clean scroll paddings in Navigation Drawer #9026

ehconitin opened this issue Dec 11, 2024 · 6 comments · May be fixed by #9141
Assignees
@ehconitin
Labels
scope: front Issues that are affecting the frontend side only size: short

Comments

@ehconitin
Copy link
Contributor

Current behavior

Currently, we hide the scroll in the NavigationDrawer(#8896) because, with the current implementation, it is rendered over the NavigationDrawerItems.

Image

Expected behavior

We want a clean scroll bar with correct paddings/positioning(it should not clip over NavigationDrawerItems)
@ehconitin ehconitin self-assigned this Dec 11, 2024
@ehconitin ehconitin mentioned this issue Dec 11, 2024
Merged
@Bonapara Bonapara added scope: front Issues that are affecting the frontend side only size: short labels Dec 12, 2024
@muraliSingh7
Copy link
Contributor

Hey @ehconitin I have added margin right as 9px to whole scrollable div.
Can you please tell me whether we need horizontal scrolling on overflow or it should be hidden ?

Screenshot for your reference:
Image

@ehconitin
Copy link
Contributor Author

@muraliSingh7 no horizontal scrolling!

@Bonapara
Copy link
Member

Navigation item overflow should be hidden with ellipsis indeed [...]

@muraliSingh7
Copy link
Contributor

Screenshot :
Image
Image

Is this what you expect @Bonapara @ehconitin ?

@ehconitin
Copy link
Contributor Author

Could you please create a PR so @Bonapara and I can test out the new behavior and verify if it's working as expected?

@muraliSingh7 muraliSingh7 mentioned this issue Dec 18, 2024
Closed
@muraliSingh7
Copy link
Contributor

@Bonapara @ehconitin I have created a PR could you please test this on your end and provide any suggestions or feedback? Thank you!

@ehconitin ehconitin linked a pull request Dec 19, 2024 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ehconitin ehconitin

Labels
scope: front Issues that are affecting the frontend side only size: short
Projects
Product development ✅
Status: 🆕 New
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Navigation drawer scroll padding fix ehconitin/twenty
3 participants
@Bonapara @muraliSingh7 @ehconitin