Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Long task names overflow the task container UI and are not selectable in multi-select mode #8803

Closed
phjackl3 opened this issue Nov 29, 2024 · 10 comments · Fixed by #9009
Closed
Assignees

Comments

@phjackl3
Copy link

Bug Description

Tasks with long task names overflow the task container UI when looking at tasks on the Kanban board. Image attached.
Image

Because the select box is at the right of the task name, and because the task name overflows in the UI, it is not possible to click the select box for tasks that have overflowed.

Example:
Create a task with the name 1234.
Create another task with the name 1234567890abcdefghijklmnopqrstuvwxyz
Go to tasks -> by status.
The task with the long name overflows the task container in the UI.
Hover over the task with the short name. A select box appears in the top right of the task container.
Hover over the task with a long name. No select box appears.

Expected behavior

Tasks with long task names should truncate before the end of the container UI. The select box for a task should be visible in the UI even for tasks with long names that need an ellipsis.

@Lucifer4255
Copy link
Contributor

Can I work on this issue @Bonapara ?

@Bonapara
Copy link
Member

hi @Lucifer4255, I think the core team will handle it as it's an high-priority bug. Thanks! (and thanks @phjackl3 for raising the issue!)

@Bonapara Bonapara moved this from 🆕 New to 🔖 Planned in Product development ✅ Nov 29, 2024
@FelixMalfait FelixMalfait changed the title Ex: Long task names overflow the task container UI and are not selectable in multi-select mode Long task names overflow the task container UI and are not selectable in multi-select mode Nov 29, 2024
@Lucifer4255
Copy link
Contributor

Hi @Bonapara I still checked this error we can easily solve this by truncating the task.title upto a certain length but the page is not rendering my changes in dev env

@Bonapara
Copy link
Member

Bonapara commented Dec 2, 2024

If it's a small change, feel free to submit a PR, @Lucifer4255. It's not guaranteed to be merged, though!

@guillim
Copy link
Contributor

guillim commented Dec 9, 2024

@Lucifer4255 I am going to work on this topic. Can you send me the branch or the PR if any ?

@Lucifer4255
Copy link
Contributor

Hi @guillim i have mentioned the pr in the chat you can check

@guillim
Copy link
Contributor

guillim commented Dec 9, 2024

I looked at your PR but I see one big drawback : the trimming will not be responsive so it's not the best option for the users.

I haven't worked on that so far, so I am curious : how come the overflow ellipsis or something equivalent in CSS doesn't work ?

@Lucifer4255
Copy link
Contributor

Well i tried to edit through CSS it clearly doesn't works and also if i try to edit the overflowingtextwithtooltip.tsx it will affect every component which uses despite we dont need to truncate in them or not

@guillim
Copy link
Contributor

guillim commented Dec 9, 2024

I get it. I will have a look in the coming days to see if I can find a CSS way to do this. I'll let you know what I come up with. Keep me posted as well !

@charlesBochet charlesBochet moved this from 🔖 Planned to 🏗 In Progress in Product development ✅ Dec 11, 2024
@guillim
Copy link
Contributor

guillim commented Dec 11, 2024

I followed as much as i could a CSS way to fix it. I opened a PR here #9009 so you can have a look @Lucifer4255 . I am still waiting for a core team review before we merge that.

As you can see I tried to touch as less as possible the components, while bringing the CSS behavior as required.

Longest part was to check that all impacted component in the app remained unchanged TBH !

@guillim guillim moved this from 🏗 In Progress to 👀 In review in Product development ✅ Dec 11, 2024
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Product development ✅ Dec 11, 2024
@guillim guillim moved this from ✅ Done to 🔦 In QA in Product development ✅ Dec 11, 2024
@guillim guillim moved this from 🔦 In QA to ✅ Done in Product development ✅ Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

5 participants