-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability to select a default country for the Address and Phone fields #8081
Comments
Good point. We already have a similar capabilty for currency (default unit) so whoever implements this can take inspiration from it. We should also consider adding it for phones (but for phone we should be able to leave it as blank / with no default country, like today) |
@Bonapara looks good! |
Can you assign this to me? |
Sure @sreyas-b-anand, thanks for contributing! |
I see that the previous contributor was removed, would you be able to assign this to me? @Bonapara |
Sure @sri-c9 , thanks for contributing! |
sorry i thought this was nextjs not nestjs |
Question to @Bonapara :
Screen.Recording.2024-11-19.at.18.33.40.mov |
@guillim great point, we can add a "No country" value in the dropdown |
@guillim I checked after our conversation and the default currency is actually set on the frontend when editing a currency field. Which means it's set to null by default but if you open/close the input then it'll be set to your default value. We don't really feel it on the currency field because there's also an additional condition so that we shouldn't display anything unless the amount is not null. For the address field type it's slightly more annoying because if we open/close the address field and it has a default value, then the country will become visible in read-only mode because we don't require setting an address to display it.
Overall I don't think it's worth overthinking this feature. We should go with whatever makes more sense for you. |
Hi @Bonapara! I am currently working in a group of 5 students from CMU taking an introductory software engineering course and our final project is to contribute to an open-source repo. Our project has multiple checkpoints and will be due on December 8 (meaning our PR will take longer to open). Would it be possible for us to be assigned to this issue (or any issues that you think would be a good fit)? Thanks! |
Sorry @JorgeGraciaViveros, @guillim is already on it |
Scope & Context
All our opportunities, employees and other contacts are in the US and I would like to make Address field to use the United States as a default country. It's tiresome to change it manually all the time.
Current behavior
Currently, the Country in the Address field defaults to
null
(but shows Ascention Island for some reason, which is confusing).Expected behavior
Ability to select the default country on the field level for Address field. I think it would be also useful to add an ability to use a default State for companies that operate only in a single State.
The text was updated successfully, but these errors were encountered: