Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve table unnamed record cells behavior #7851

Open
Bonapara opened this issue Oct 19, 2024 · 31 comments
Open

Improve table unnamed record cells behavior #7851

Bonapara opened this issue Oct 19, 2024 · 31 comments

Comments

@Bonapara
Copy link
Member

Bonapara commented Oct 19, 2024

Current Behavior

Behavior of records without a name:

  • Default state: An empty cell is displayed.
  • Hover state: A chip with the record icon identifier appears. Clicking on it allows the user to navigate to the record detail page. Clicking the empty cell allows renaming the record. No arrow up right floating icon button is displayed.
CleanShot.2024-10-19.at.15.55.13.mp4

Desired Behavior

Default State

  • Remain as is (Empty).

Hover State

  • Do not display the relation chip.
  • Show Set Name as a placeholder. On click, open the name input.
  • Display the arrow up right floating icon button, similar to records with a name, to navigate to the record detail page.
CleanShot.2024-10-19.at.16.13.56.mp4

Figma

Make sure to update the component

image

https://www.figma.com/design/xt8O9mFeLl46C5InWwoMrN/Twenty?node-id=14603-76540&node-type=frame&t=iBqOKbAA8s4yWFu2-11

@Bonapara
Copy link
Member Author

/oss.gg 300

Copy link

oss-gg bot commented Oct 19, 2024

Thanks for opening an issue! It's live on oss.gg!

@adityadeshlahre
Copy link
Contributor

/assign

Copy link

oss-gg bot commented Oct 19, 2024

Assigned to @adityadeshlahre! Please open a draft PR linking this issue within 48h ⚠️ If we can't detect a PR from you linking this issue in 48h, you'll be unassigned automatically 🕹️ Excited to have you ship this 🚀

@naaa760
Copy link

naaa760 commented Oct 19, 2024

/assign

Copy link

oss-gg bot commented Oct 19, 2024

This issue is already assigned to another person. Please find more issues here.

@sanjay-gangwar4410
Copy link

/assign

Copy link

oss-gg bot commented Oct 19, 2024

This issue is already assigned to another person. Please find more issues here.

@pramittt
Copy link

/assign

Copy link

oss-gg bot commented Oct 21, 2024

This issue is already assigned to another person. Please find more issues here.

@adityadeshlahre adityadeshlahre removed their assignment Oct 22, 2024
@adityadeshlahre
Copy link
Contributor

Hey @Bonapara and @naaa760 @sanjay-gangwar4410 @pramittt this issue is open to take!
it seems like this issue needs more context-gathering { I tried with my local setup done } I wasn't able to replicate the desired behavior in the Companies Tab. Hence it was hard to get this done for me so I am unassigning this issue.

POV

replication

you guys can get this issue assigned 🙂
I think I need to give more time to twenty repo 🕐

Thank You

@sanjay-gangwar4410
Copy link

/assign

Copy link

oss-gg bot commented Oct 23, 2024

Assigned to @sanjay-gangwar4410! Please open a draft PR linking this issue within 48h ⚠️ If we can't detect a PR from you linking this issue in 48h, you'll be unassigned automatically 🕹️ Excited to have you ship this 🚀

@Vardhaman619
Copy link
Contributor

/assign

Copy link

oss-gg bot commented Oct 24, 2024

This issue is already assigned to another person. Please find more issues here.

Copy link

oss-gg bot commented Oct 24, 2024

@sanjay-gangwar4410, please open a draft PR linking this issue within 12 hours. If we can't detect a PR in 12 hours, you will be unassigned automatically.

Copy link

oss-gg bot commented Oct 25, 2024

@sanjay-gangwar4410 has not opened a PR for this issue within 48 hours. They have been unassigned from the issue; anyone can now take it up.

@Vardhaman619
Copy link
Contributor

/assign

Copy link

oss-gg bot commented Oct 25, 2024

You already have an open issue assigned to you here. Once that's closed or unassigned, only then we recommend you to take up more.

@sanjay-gangwar4410
Copy link

/assign

Copy link

oss-gg bot commented Oct 25, 2024

Assigned to @sanjay-gangwar4410! Please open a draft PR linking this issue within 48h ⚠️ If we can't detect a PR from you linking this issue in 48h, you'll be unassigned automatically 🕹️ Excited to have you ship this 🚀

Copy link

oss-gg bot commented Oct 26, 2024

@sanjay-gangwar4410, please open a draft PR linking this issue within 12 hours. If we can't detect a PR in 12 hours, you will be unassigned automatically.

Copy link

oss-gg bot commented Oct 27, 2024

@sanjay-gangwar4410 has not opened a PR for this issue within 48 hours. They have been unassigned from the issue; anyone can now take it up.

@Vardhaman619
Copy link
Contributor

/assign

Copy link

oss-gg bot commented Oct 27, 2024

Assigned to @Vardhaman619! Please open a draft PR linking this issue within 48h ⚠️ If we can't detect a PR from you linking this issue in 48h, you'll be unassigned automatically 🕹️ Excited to have you ship this 🚀

@Vardhaman619 Vardhaman619 removed their assignment Oct 27, 2024
Copy link

oss-gg bot commented Oct 28, 2024

@Vardhaman619, please open a draft PR linking this issue within 12 hours. If we can't detect a PR in 12 hours, you will be unassigned automatically.

@Pk9697
Copy link
Contributor

Pk9697 commented Oct 29, 2024

/assign

@oss-gg oss-gg bot assigned Pk9697 Oct 29, 2024
Copy link

oss-gg bot commented Oct 29, 2024

Assigned to @Pk9697! Please open a draft PR linking this issue within 48h ⚠️ If we can't detect a PR from you linking this issue in 48h, you'll be unassigned automatically 🕹️ Excited to have you ship this 🚀

Copy link

oss-gg bot commented Oct 30, 2024

@Pk9697, please open a draft PR linking this issue within 12 hours. If we can't detect a PR in 12 hours, you will be unassigned automatically.

Copy link

oss-gg bot commented Oct 31, 2024

@Pk9697 has not opened a PR for this issue within 48 hours. They have been unassigned from the issue; anyone can now take it up.

@oss-gg oss-gg bot unassigned Pk9697 Oct 31, 2024
@Pk9697
Copy link
Contributor

Pk9697 commented Oct 31, 2024

/assign

@oss-gg oss-gg bot assigned Pk9697 and unassigned Pk9697 Oct 31, 2024
@twentyhq twentyhq deleted a comment from oss-gg bot Nov 4, 2024
@twentyhq twentyhq deleted a comment from oss-gg bot Nov 4, 2024
@twentyhq twentyhq deleted a comment from oss-gg bot Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 🆕 New
Development

No branches or pull requests

7 participants