Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Created by should not have left & right margins #7164

Open
Bonapara opened this issue Sep 19, 2024 · 12 comments
Open

Created by should not have left & right margins #7164

Bonapara opened this issue Sep 19, 2024 · 12 comments
Labels
good first issue Good for newcomers prio: low scope: front Issues that are affecting the frontend side only size: short type: design improvement

Comments

@Bonapara
Copy link
Member

Bonapara commented Sep 19, 2024

Current behavior

The Created by chip has a 4px margin on both the left and right sides.

26c80322be1d8255ef2f9dccf9f5867fed7cb9d1cb2c3d0a1259a24115ddff76

Desired Behavior

Remove the chip as it's not a relation. This should allow content to be vertically aligned with text fields on kanban cards and on record pages.

Make sure it doesn't break anything else

CleanShot 2024-09-19 at 19 17 13

@GARY121github
Copy link
Contributor

Hello @Bonapara Can I work on this issue ?

@Bonapara
Copy link
Member Author

Sure @GARY121github, thanks for contributing!

@maheswar-dileep
Copy link

@GARY121github are you still working on this issue??
@Bonapara If not please assign it to me.

@Bonapara
Copy link
Member Author

Unassigning you, @GARY121github, as it's been three weeks, and assigning you, @maheswar-dileep. Thank you both for contributing!

@vamus092
Copy link

is the issue resolved otherwise i can work on that
@Bonapara

@Bonapara
Copy link
Member Author

Nope @vamus092!

@khuddite
Copy link
Contributor

khuddite commented Nov 6, 2024

I am looking into the issue

@khuddite
Copy link
Contributor

khuddite commented Nov 6, 2024

@Bonapara Are we gonna remove the Created by option from the Kanban board, so there is no way to see Created by field on the cards? Or are we just gonna hide it by default so it shows up here where you can make it visible as necessary?

CleanShot 2024-11-06 at 09 20 50

@khuddite
Copy link
Contributor

khuddite commented Nov 6, 2024

Oh, I think I got you. If you meant to remove the avatar(CSV in ur screenshot, T in mine), I think it will cause some inconsistencies because 'Created by` is not the only field that has an avatar.

CleanShot 2024-11-06 at 10 00 40

For ex, here, Company field also has an associated avatar.

@Bonapara
Copy link
Member Author

Bonapara commented Nov 7, 2024

Hi @khuddite, I mean remove the margins/paddings from the "created by" that seems to be in an invisible chip.

@khuddite
Copy link
Contributor

khuddite commented Nov 7, 2024

CleanShot 2024-11-07 at 09 31 53

I think it requires many more changes than just removing padding/margin from the Created by chip. Honestly I think making that one change might cause more problems than it solves. For example, in the above screenshot, many columns (like name, email, creation date, city, etc) are not vertically aligned between the header and content.

This is a file that has all different types of fields - https://github.com/twentyhq/twenty/blob/a58236e6dae7c8ccb4375ca5e2ca2e8f9c957cb7/packages/twenty-front/src/modules/object-record/record-field/components/FieldDisplay.tsx

@Bonapara
Copy link
Member Author

Bonapara commented Nov 8, 2024

@khuddite everything has a 6px margin left in cells. But created by has a 6px left + 4px empty chip that should be removed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers prio: low scope: front Issues that are affecting the frontend side only size: short type: design improvement
Projects
Status: 🆕 New
Development

No branches or pull requests

5 participants