Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance picture uploader #6966

Closed
Bonapara opened this issue Sep 10, 2024 · 8 comments · Fixed by #6974
Closed

Enhance picture uploader #6966

Bonapara opened this issue Sep 10, 2024 · 8 comments · Fixed by #6974
Labels
good first issue Good for newcomers prio: low scope: front Issues that are affecting the frontend side only size: short type: design improvement

Comments

@Bonapara
Copy link
Member

Current behavior

  1. The Remove button is red
  2. The label is not well positioned

CleanShot 2024-09-10 at 11 38 31

Desired Behavior

Buttons

The button should be secondary and set to "hug content" rather than "fill content"

Activated:

CleanShot 2024-09-10 at 11 34 51

Deactivated:

CleanShot 2024-09-10 at 11 35 23

Label

The label should be under the buttons and not at the bottom of the container

CleanShot 2024-09-10 at 11 37 11

@Bonapara Bonapara added good first issue Good for newcomers scope: front Issues that are affecting the frontend side only size: short labels Sep 10, 2024
@VriaA
Copy link

VriaA commented Sep 10, 2024

Hi! Can I work on this?

@Bonapara
Copy link
Member Author

Sure @VriaA, thanks for contributing!

@heber59
Copy link
Contributor

heber59 commented Sep 10, 2024

i submit a pull request, I read you policy abut assigned issues but i start working on it beffore u assigned it and what to help :) hope u could see it.

@Bonapara
Copy link
Member Author

@VriaA, do you mind creating another Good First Issue this time?

@VriaA
Copy link

VriaA commented Sep 11, 2024

@Bonapara I don’t. I’ll work on something else since @heber59 already created a pull request.

@Bonapara
Copy link
Member Author

Thanks a lot @VriaA :)

@Smnthjm08
Copy link

can i work on this @Bonapara , i'm new to open source

@Bonapara
Copy link
Member Author

Hi @Smnthjm08, unfortunately, there is already a PR for this one! Maybe you can grab another Good First Issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers prio: low scope: front Issues that are affecting the frontend side only size: short type: design improvement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants