Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When scrolling inside the table with scrollbar, cursor also selects rows #6773

Open
BOHEUS opened this issue Aug 28, 2024 · 33 comments
Open
Assignees
Labels
good first issue Good for newcomers scope: front Issues that are affecting the frontend side only

Comments

@BOHEUS
Copy link
Contributor

BOHEUS commented Aug 28, 2024

Scenario:

  1. Log in
  2. Go to object page (e.g. Companies)
  3. Create at least 100 objects so table won't be able to load them all thanks to pagination and scroll will appear
  4. Scroll a bit for the scrollbar to appear and try to use scrollbar to move up/down the table

Actual: When moving scrollbar, cursor also is able to select multiple rows
Screencast from 2024-08-28 18-35-28.webm

Expected: When moving scrollbar, cursor is only moving scrollbar

@BOHEUS BOHEUS changed the title When scrolling inside the table, cursor also selects rows When scrolling inside the table with scrollbar, cursor also selects rows Aug 28, 2024
@Faisal-imtiyaz123
Copy link
Contributor

@BOHEUS I would like to work here.

@Bonapara Bonapara added good first issue Good for newcomers scope: front Issues that are affecting the frontend side only labels Aug 29, 2024
@Bonapara
Copy link
Member

Sure @Faisal-imtiyaz123, thanks for contributing!

@janvi01
Copy link

janvi01 commented Aug 31, 2024

I would like to work on this @Bonapara

@charlesBochet
Copy link
Member

I can reproduce should be easy to fix, we should de-activate the drag start on the scrollbar. We already have this kind of mechanism to not start the drag on column header click

@Bonapara
Copy link
Member

Bonapara commented Sep 2, 2024

@Faisal-imtiyaz123 are you still on it? Otherwise will assign you @janvi01. Thank you both for contributing!

@Faisal-imtiyaz123
Copy link
Contributor

@Bonapara I am on it.

@Faisal-imtiyaz123
Copy link
Contributor

@BOHEUS I made 120 objects . Couldn't reproduce it. Are you sure it wasn't an accidental selection which caused rows to be selected.

@BOHEUS
Copy link
Contributor Author

BOHEUS commented Sep 4, 2024

@Faisal-imtiyaz123 I'm still reproducing it, both locally on newest changes and on demo, I'm sure it wasn't an accidental selection as I clicked on scroll (sadly, it's not visible on video as software didn't capture a cursor for some weird reason) and @charlesBochet confirmed it can be reproduced, I also checked and it's not limited to specific browser like it's in some cases

@Faisal-imtiyaz123
Copy link
Contributor

@BOHEUS Oh! I think it is reproducible when number of objects is large. Let me create a large number of objects and then see.

@Bonapara
Copy link
Member

Bonapara commented Oct 1, 2024

/oss.gg 150

Copy link

oss-gg bot commented Oct 1, 2024

Thanks for opening an issue! It's live on oss.gg!

@oss-gg oss-gg bot added the 🕹️ oss.gg label Oct 1, 2024
@Prathamm-sahu
Copy link

/assign

Copy link

oss-gg bot commented Oct 8, 2024

Assigned to @Prathamm-sahu! Please open a draft PR linking this issue within 48h ⚠️ If we can't detect a PR from you linking this issue in 48h, you'll be unassigned automatically 🕹️ Excited to have you ship this 🚀

Copy link

oss-gg bot commented Oct 9, 2024

@Prathamm-sahu, Just a little reminder: Please open a draft PR linking this issue within 12 hours. If we can't detect a PR in 12h, you will be unassigned automatically.

@HarshBytesCode
Copy link

/assign

Copy link

oss-gg bot commented Oct 11, 2024

This issue is already assigned to another person. Please find more issues here.

@Anky9972
Copy link

/assign

Copy link

oss-gg bot commented Oct 11, 2024

This issue is already assigned to another person. Please find more issues here.

@xRiddin
Copy link

xRiddin commented Oct 11, 2024

/assign

Copy link

oss-gg bot commented Oct 11, 2024

This issue is already assigned to another person. Please find more issues here.

Copy link

oss-gg bot commented Oct 11, 2024

@Prathamm-sahu, Just a little reminder: Please open a draft PR linking this issue within 12 hours. If we can't detect a PR in 12h, you will be unassigned automatically.

@hr188
Copy link

hr188 commented Oct 12, 2024

/assign

Copy link

oss-gg bot commented Oct 12, 2024

This issue is already assigned to another person. Please find more issues here.

@TechWithAkash
Copy link

/assign

Copy link

oss-gg bot commented Oct 12, 2024

This issue is already assigned to another person. Please find more issues here.

@charlesBochet
Copy link
Member

/unassign

Copy link

oss-gg bot commented Oct 13, 2024

Issue unassigned.

@TriDev5
Copy link

TriDev5 commented Oct 13, 2024

/assign

@oss-gg oss-gg bot assigned TriDev5 Oct 13, 2024
Copy link

oss-gg bot commented Oct 13, 2024

Assigned to @TriDev5! Please open a draft PR linking this issue within 48h ⚠️ If we can't detect a PR from you linking this issue in 48h, you'll be unassigned automatically 🕹️ Excited to have you ship this 🚀

@Sukhpreet7137
Copy link

/assign

Copy link

oss-gg bot commented Oct 13, 2024

This issue is already assigned to another person. Please find more issues here.

Copy link

oss-gg bot commented Oct 13, 2024

@Prathamm-sahu, Just a little reminder: Please open a draft PR linking this issue within 12 hours. If we can't detect a PR in 12h, you will be unassigned automatically.

Copy link

oss-gg bot commented Oct 16, 2024

@TriDev5, Just a little reminder: Please open a draft PR linking this issue within 12 hours. If we can't detect a PR in 12h, you will be unassigned automatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers scope: front Issues that are affecting the frontend side only
Projects
None yet
Development

No branches or pull requests