Hide System Field Updates in Record Page Timelines

[Bonapara]

Current Behavior

Some system field updates are displayed in record page timelines. However, as they lack a FieldDisplay, no value appears near the field title.

Desired Behavior

We shouldn't display system fields in the timeline.

[Faisal-imtiyaz123]

@Bonapara I would like to work here.

[Bonapara]

Sure @Faisal-imtiyaz123, thanks for contributing!

[charlesBochet]

@Bonapara @FelixMalfait should we rather add a isAuditable on field level?

I don't like the isSystem one :p
We have a settings column on Fields, we plan to add things in it such as: isSearchable, we could add isAuditable there too

[FelixMalfait]

@charlesBochet At the field-level it's a bit more subtle than isAuditable because we still want these fields to be audit-logged but we don't want the timelineActivity to display include them, so I'd advocate for a different name (isDisplayedInTimelineActivity or something like that).
But I don't see a case where a field would be displayed in the page, and wouldn't be displayed in the timeline.
So in my opinion, the field we should use here is the same we will introduce to replace most use-cases for isSystem (isDisplayed or something like that).
Bottom line is I think we should use isSystem

[charlesBochet]

Okay I understand the reasoning! Let's go for isSystem as long as we don't have a better naming

[FelixMalfait]

Changing to GoodFirstIssue as it shouldn't be too difficult.
We should filter out fields where isSystem = true in the diff.
Think about the edge case where just 1 field was changed (e.g. position was changed by dragging the item on the list view), then we don't want to create any timelineActivity.

Do it on the backend rather than on the frontend. I would probably do it in EntityEventsToDbListener

[Bonapara]

/oss.gg 150

[oss-gg]

Thanks for opening an issue! It's live on oss.gg!

[Harsh-Sanklecha]

/assign

[oss-gg]

Assigned to @Harsh-Sanklecha! Please open a draft PR linking this issue within 48h ⚠️ If we can't detect a PR from you linking this issue in 48h, you'll be unassigned automatically 🕹️ Excited to have you ship this 🚀

[raaaaj214]

/assign

[oss-gg]

Assigned to @raaaaj214! Please open a draft PR linking this issue within 48h ⚠️ If we can't detect a PR from you linking this issue in 48h, you'll be unassigned automatically 🕹️ Excited to have you ship this 🚀

[oss-gg]

@Harsh-Sanklecha, Just a little reminder: Please open a draft PR linking this issue within 12 hours. If we can't detect a PR in 12h, you will be unassigned automatically.

[nilaygit-10721]

/assign

[oss-gg]

This issue is already assigned to another person. Please find more issues here.

[parthmodi152]

/assign

[oss-gg]

@raaaaj214, Just a little reminder: Please open a draft PR linking this issue within 12 hours. If we can't detect a PR in 12h, you will be unassigned automatically.

[charlesBochet]

/unassign

[oss-gg]

Issue unassigned.

[sudarshana133]

/assign

[oss-gg]

Assigned to @sudarshana133! Please open a draft PR linking this issue within 48h ⚠️ If we can't detect a PR from you linking this issue in 48h, you'll be unassigned automatically 🕹️ Excited to have you ship this 🚀

[sudarshana133]

/unassign

[oss-gg]

Issue unassigned.

[Heisen47]

/assign

[oss-gg]

Assigned to @Heisen47! Please open a draft PR linking this issue within 48h ⚠️ If we can't detect a PR from you linking this issue in 48h, you'll be unassigned automatically 🕹️ Excited to have you ship this 🚀

[oss-gg]

@sudarshana133, Just a little reminder: Please open a draft PR linking this issue within 12 hours. If we can't detect a PR in 12h, you will be unassigned automatically.

[oss-gg]

@Heisen47, Just a little reminder: Please open a draft PR linking this issue within 12 hours. If we can't detect a PR in 12h, you will be unassigned automatically.

[oss-gg]

@raaaaj214, Just a little reminder: Please open a draft PR linking this issue within 12 hours. If we can't detect a PR in 12h, you will be unassigned automatically.

[Heisen47]

/unassign

[oss-gg]

Issue unassigned.

[razamzai]

/assign

[oss-gg]

Assigned to @razamzai! Please open a draft PR linking this issue within 48h ⚠️ If we can't detect a PR from you linking this issue in 48h, you'll be unassigned automatically 🕹️ Excited to have you ship this 🚀

[Khaan25]

Hey @Bonapara, May I ask what are the steps to reproduce it? I've tried to find the Position to change but could find any field.

[Bonapara]

Sure:

CleanShot.2024-10-18.at.14.54.03.mp4

[Khaan25]

Thank you very much

[Khaan25]

@Bonapara, I've fixed other issues I've had. I would love to work on this issue as well.

[Bonapara]

@razamzai are you still on it?

[Khaan25]

Hey, could you assign me :)

My other PRs is under review. I can quickly wrap this up as well