Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace entityId by recordId in the front end. #6334

Closed
lucasbordeau opened this issue Jul 19, 2024 · 4 comments
Closed

Replace entityId by recordId in the front end. #6334

lucasbordeau opened this issue Jul 19, 2024 · 4 comments
Assignees
@ehconitin
Labels
good first issue Good for newcomers type: chore

Comments

@lucasbordeau
Copy link
Contributor

Scope & Context

We used entityId quite everywhere before we settled for recordId.

Technical inputs

Now entityId doesn't correspond to our naming, so we should replace it by recordId and rename everything that has entityId in its naming :

  • Variables
  • States
  • Functions
  • Hooks
  • Etc.
@devansh-m12
Copy link

can i work on this issue ?

@FurquanAnwer
Copy link

@lucasbordeau Could you assign me this issue ?

@maheshcodes12
Copy link

I would love to work on this issue.

@ehconitin
Copy link
Contributor

Hey @lucasbordeau,

I have created a pull request to address this issue. Please check it here: PR #6355

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ehconitin ehconitin

Labels
good first issue Good for newcomers type: chore
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@FelixMalfait @lucasbordeau @FurquanAnwer @devansh-m12 @maheshcodes12 @ehconitin