Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graph Button in Data Model Settings Blends with Background #6223

Closed
Bonapara opened this issue Jul 11, 2024 · 2 comments · Fixed by #6234
Closed

Graph Button in Data Model Settings Blends with Background #6223

Bonapara opened this issue Jul 11, 2024 · 2 comments · Fixed by #6234
Labels
good first issue Good for newcomers scope: front Issues that are affecting the frontend side only

Comments

@Bonapara
Copy link
Member

Current behavior

In Settings > Data model, the Graph button is indistinguishable from the background.

CleanShot 2024-07-11 at 17 35 55

Desired Behavior

Use the Floating button instead:

https://storybook.twenty.com/?path=/story/ui-input-button-floatingbutton--catalog

@Bonapara Bonapara added good first issue Good for newcomers scope: front Issues that are affecting the frontend side only size: minutes labels Jul 11, 2024
Copy link
Contributor

greptile-apps bot commented Jul 11, 2024

Replace the current Graph button in SettingsDataModelOverview.tsx with the FloatingButton component from FloatingButton.tsx.

  1. Import FloatingButton in SettingsDataModelOverview.tsx:
import { FloatingButton } from '@/ui/input/button/components/FloatingButton';
  1. Replace the current button with FloatingButton:
<StyledCloseButton>
  <FloatingButton Icon={IconX} title="Close" to="/settings/objects" />
</StyledCloseButton>

References

/packages/twenty-front/src/modules/settings/data-model/graph-overview/components/SettingsDataModelOverview.tsx
/packages/twenty-front/src/modules/ui/input/button/components/FloatingButton.tsx
/packages/twenty-front/src/modules/ui/input/button/components

About Greptile

This response provides a starting point for your research, not a precise solution.

Help us improve! Please leave a 👍 if this is helpful and 👎 if it is irrelevant.

Ask Greptile · Edit Issue Bot Settings

@Faisal-imtiyaz123
Copy link
Contributor

@Bonapara Please assign me. I raised a P.R on the last assigned one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers scope: front Issues that are affecting the frontend side only
Projects
Archived in project
2 participants