Skip to content

As admin, I can impersonate users #594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
FelixMalfait opened this issue Jul 11, 2023 · 1 comment · Fixed by #976
Closed

As admin, I can impersonate users #594

FelixMalfait opened this issue Jul 11, 2023 · 1 comment · Fixed by #976
Assignees
Labels
scope: back+front Issues requiring full-stack knowledge

Comments

@FelixMalfait
Copy link
Member

FelixMalfait commented Jul 11, 2023

(1) Create columns on table users
First column:canImpersonate (false by default)
Second column: allowsImpersonation (true by default)

(2) Create new endpoint /impersonate/{userId}
That endpoints check that the logged-in user has the required privilege to impersonate, then proceeds to re-login as the user, then redirects to the home page or shows an error if the user isn't found or the logged in user doesn't have the required privileges

(3) Todo later (not for this issue):
Give the user an easy way to revert to his admin account (For now the user can go to settings > logout and re-login)

Note: CRMs like Salesforce or Hubspot allow workspace admin to impersonate their team member. Probably a bit premature since we don't have a strong permissionning system yet but maybe something to have in mind as we design this

@FelixMalfait FelixMalfait moved this from 🆕 New to 🔖 Planned in 🎯 Roadmap & Sprints Jul 11, 2023
@FelixMalfait FelixMalfait changed the title Impersonation feature As admin, I can impersonate users Jul 23, 2023
@FelixMalfait FelixMalfait added the blocked: design needed This doesn't seem right label Jul 23, 2023
@Bonapara Bonapara removed the blocked: design needed This doesn't seem right label Jul 24, 2023
@FelixMalfait FelixMalfait added scope: back+front Issues requiring full-stack knowledge ready labels Jul 24, 2023
@FelixMalfait FelixMalfait removed their assignment Jul 24, 2023
@magrinj magrinj self-assigned this Jul 28, 2023
@magrinj magrinj moved this from 🔖 Planned to 🏗 In progress in 🎯 Roadmap & Sprints Jul 28, 2023
@magrinj magrinj linked a pull request Jul 28, 2023 that will close this issue
@magrinj magrinj moved this from 🏗 In progress to 👀 In review in 🎯 Roadmap & Sprints Jul 31, 2023
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in 🎯 Roadmap & Sprints Jul 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: back+front Issues requiring full-stack knowledge
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants