Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce position column on ObjectMetadata #4889

Closed
Tracked by #6445
FelixMalfait opened this issue Apr 9, 2024 · 3 comments
Closed
Tracked by #6445

Introduce position column on ObjectMetadata #4889

FelixMalfait opened this issue Apr 9, 2024 · 3 comments

Comments

@FelixMalfait
Copy link
Member

FelixMalfait commented Apr 9, 2024

  • add a column position on ObjectMetadata to determine if it should be displayed on the app's left menu and its position
  • add a column isDisplayedInMenu (default value false)
  • improve @WorkspaceEntity decorator to take into account those two additional positions initialize people/companies/opportunities with big numbers to leave room in the future (e.g. -1000000 0 100000), make sure it's properly initialized for custom objects (added at the end)

Frontend: menu will be re-ordered the same way we re-order favorites (will be done later / in another issue)

@FelixMalfait FelixMalfait changed the title Rename isSystem on ObjectMetadata and introduce menuItems Introduce position column on ObjectMetadata Apr 9, 2024
@FelixMalfait
Copy link
Member Author

(the primary goal of this is to decorrelate visibility of an object in the app and visibility in settings, it'd be useful to expose some objects in settings without having them appearing automatically on the sidebar)

@FelixMalfait
Copy link
Member Author

Marking as blocked as I feel the separation could also depend on the Layout, depending on our strategy to implement layouts

@FelixMalfait
Copy link
Member Author

Instead we we'll use Favorites to decorelate menu from objects. Not all objects will be displayed in the menu

@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in Product development ✅ Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: ✅ Done
Development

No branches or pull requests

1 participant