-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support custom field deletion for custom composite fields #4841
Comments
I've added a description with technical inputs |
ijreilly
changed the title
Bug: Custom field deletion is failing for composite fields
Support custom field deletion for custom composite fields
May 7, 2024
How can we manually delete these fields? |
github-project-automation
bot
moved this from 📋 Backlog
to ✅ Done
in Product development ✅
Jul 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Context
This bug was fixed by not allowing the deletion of such fields. Let's support it!
Old:
TypeORM is throwing an error due to the fact that we are asking the ORM to delete a column that does not exist. This is expected since composite fields are not simply 1:1 with the fieldMetadata but result in different columns. For example, an ADDRESS field will be mapped to multiple columns (xxx_street, xxx_state, ...).
Technical inputs
We should update the field_metadata service to handle composite fields.
We can use utils such as isCompositeFieldMetadataType and CompositeFieldsDefinitionFunction to get the correct column names.
The text was updated successfully, but these errors were encountered: