Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support custom field deletion for custom composite fields #4841

Closed
ijreilly opened this issue Apr 5, 2024 · 2 comments · Fixed by #6320
Closed

Support custom field deletion for custom composite fields #4841

ijreilly opened this issue Apr 5, 2024 · 2 comments · Fixed by #6320
Assignees

Comments

@ijreilly
Copy link
Collaborator

ijreilly commented Apr 5, 2024

Context

This bug was fixed by not allowing the deletion of such fields. Let's support it!

Old:
TypeORM is throwing an error due to the fact that we are asking the ORM to delete a column that does not exist. This is expected since composite fields are not simply 1:1 with the fieldMetadata but result in different columns. For example, an ADDRESS field will be mapped to multiple columns (xxx_street, xxx_state, ...).

Technical inputs

We should update the field_metadata service to handle composite fields.
We can use utils such as isCompositeFieldMetadataType and CompositeFieldsDefinitionFunction to get the correct column names.

@ijreilly ijreilly self-assigned this Apr 5, 2024
@ijreilly ijreilly converted this from a draft issue Apr 5, 2024
@Weiko Weiko added the type: bug label Apr 5, 2024
@Weiko
Copy link
Member

Weiko commented Apr 5, 2024

I've added a description with technical inputs

@ijreilly ijreilly moved this from 🔖 Planned to 📋 Backlog in Product development ✅ Apr 8, 2024
@FelixMalfait FelixMalfait added the T label Apr 15, 2024
@ijreilly ijreilly changed the title Bug: Custom field deletion is failing for composite fields Support custom field deletion for custom composite fields May 7, 2024
@ijreilly ijreilly removed the type: bug label May 7, 2024
@FelixMalfait FelixMalfait added the K label Jun 7, 2024
@mnbro
Copy link

mnbro commented Jul 12, 2024

How can we manually delete these fields?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

4 participants