Skip to content

⌛ Improve loading with Skeleton Loading #4462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
4 tasks done
Bonapara opened this issue Mar 13, 2024 · 16 comments
Closed
4 tasks done

⌛ Improve loading with Skeleton Loading #4462

Bonapara opened this issue Mar 13, 2024 · 16 comments
Assignees

Comments

@Bonapara
Copy link
Member

Desired Behavior

We aim to improve page loading by adding more skeleton loading.

Here is the desired behaviors:

Table indexes

Screen.Recording.2024-03-13.at.16.46.15.mov

Kanban indexes

Screen.Recording.2024-03-13.at.16.47.43.mov

Shows

Screen.Recording.2024-03-13.at.16.48.39.mov

Tasks

Preview Give feedback
  1. scope: front size: short
    gitstart-twenty
  2. scope: front size: short
    gitstart-twenty
  3. scope: front size: short
    gitstart-twenty
  4. scope: front size: short
    gitstart-twenty
@charlesBochet
Copy link
Member

charlesBochet commented Mar 20, 2024

Hints for technical part:

  • look at the XHR queries, you'll see:
  1. ClientConfig + CurrentUser + Metadata
  2. Prefetch
  3. Other data queries
  • look at index.tsx, you'll see:
  1. ClientConfigProvider, UserProvider, MetadataProvider
  2. PrefetchProvider
  3. Layout and rest of the app

On the figmas, you'll see different loading state corresponding to these 1, 2, 3 steps

➡️ I think it's better to do one loading state in a first PR so we can discuss technical implementation before you go to all of them ⬅️

@saadfrhan
Copy link

Hi, I will try to solve this issue.

@Bonapara
Copy link
Member Author

Bonapara commented Apr 8, 2024

Hi @saadfrhan, thanks for your contribution. Please tag me in the sub-issues you'd like to address, so I can assign them to you!

@saadfrhan
Copy link

saadfrhan commented Apr 8, 2024

@Bonapara, Can you assign me to all of them?

@Bonapara
Copy link
Member Author

Bonapara commented Apr 9, 2024

@saadfrhan, please comment on them since I cannot assign you directly.

@saadfrhan
Copy link

Oh my bad. Okay

@Bonapara
Copy link
Member Author

@saadfrhan, my apologies, I overlooked that the sub-issues were already assigned.

@saadfrhan
Copy link

No problem. 🙌

@saadfrhan
Copy link

Hi @Bonapara 👋, can you assign me to one of the sub-issues?

@Bonapara
Copy link
Member Author

Hi @saadfrhan, unfortunately, as I mentioned earlier, those tasks have already been assigned. Maybe would you like to pick another one?

@saadfrhan
Copy link

Oh ok. Thanks!

@FelixMalfait
Copy link
Member

@saadfrhan thanks and sorry for the confusion! This is a fairly big issue so make sure to break it into 1 first PR and ping us on Discord if you need intermediate feedback. @Bonapara will be happy to support you if there are design considerations

@saadfrhan
Copy link

Ok. Thanks @FelixMalfait!

@saadfrhan
Copy link

Sorry, I am unassigning myself because I am failing to do it.

@saadfrhan saadfrhan removed their assignment Apr 23, 2024
@charlesBochet
Copy link
Member

Ok no worries :) thanks for taking a look

Copy link
Contributor

gitstart-app bot commented May 1, 2024

Here is the GitStart Ticket for this issue: https://clients.gitstart.com/twenty/5449/tickets/TWNTY-4462

@Bonapara Bonapara closed this as completed Jul 1, 2024
@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in 🎯 Roadmap & Sprints Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants
@FelixMalfait @charlesBochet @Bonapara @saadfrhan @gitstart-twenty and others