Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add storybook tests on ObjectFilterDropdownOptionSelect #4316

Open
thomtrp opened this issue Mar 5, 2024 · 31 comments
Open

Add storybook tests on ObjectFilterDropdownOptionSelect #4316

thomtrp opened this issue Mar 5, 2024 · 31 comments
Assignees
Labels
good first issue Good for newcomers prio: low scope: front Issues that are affecting the frontend side only size: short type: chore

Comments

@thomtrp
Copy link
Contributor

thomtrp commented Mar 5, 2024

Scope & Context

Follow-up on this PR: #3656
New components have been added without any storybook test.

Technical inputs

File paths are the following:

  • packages/twenty-front/src/modules/ui/navigation/menu-item/components/MenuItemSelectTag.tsx
  • packages/twenty-front/src/modules/object-record/object-filter-dropdown/components/ObjectFilterDropdownOptionSelect.tsx
@thomtrp thomtrp converted this from a draft issue Mar 5, 2024
@thomtrp thomtrp added scope: front Issues that are affecting the frontend side only good first issue Good for newcomers labels Mar 5, 2024
@anoopw3bdev
Copy link
Contributor

Hi @thomtrp I took a look the folders, none of the components in packages/twenty-front/src/modules/object-record/object-filter-dropdown/components have a story, ideally when we create a new component we should write the respective story too?

@ZichenMen
Copy link

I'm going to work on this issue.

@clrminded
Copy link

I will be working on this issue as well.

@BalanaguYashwanth
Copy link

BalanaguYashwanth commented Aug 26, 2024

Hello @thomtrp,

  • MenuItemSelectTag - already story exists for this component

  • ObjectFilterDropdownOptionSelect - related to object-filter-dropdown folder, there are no stories written in it.

  • So can you close this issue and create separate issue to write stories for object-filter-dropdown folder

@charlesBochet charlesBochet changed the title Add storybook tests on new components MenuItemSelectTag and ObjectFilterDropdownOptionSelect Add storybook tests on ObjectFilterDropdownOptionSelect Sep 14, 2024
@charlesBochet
Copy link
Member

@BalanaguYashwanth Thanks for checking, I have renamed the issue

@Bonapara
Copy link
Member

Bonapara commented Oct 2, 2024

/oss.gg 150

Copy link

oss-gg bot commented Oct 2, 2024

Thanks for opening an issue! It's live on oss.gg!

@priyanshu-kun
Copy link

/assign

Copy link

oss-gg bot commented Oct 10, 2024

Assigned to @priyanshu-kun! Please open a draft PR linking this issue within 48h ⚠️ If we can't detect a PR from you linking this issue in 48h, you'll be unassigned automatically 🕹️ Excited to have you ship this 🚀

@pra2107tham
Copy link

/assign

Copy link

oss-gg bot commented Oct 11, 2024

This issue is already assigned to another person. Please find more issues here.

@yashdarji30
Copy link

/assign

Copy link

oss-gg bot commented Oct 11, 2024

This issue is already assigned to another person. Please find more issues here.

Copy link

oss-gg bot commented Oct 12, 2024

@priyanshu-kun, Just a little reminder: Please open a draft PR linking this issue within 12 hours. If we can't detect a PR in 12h, you will be unassigned automatically.

@sateshcharan
Copy link
Contributor

/assign

Copy link

oss-gg bot commented Oct 12, 2024

This issue is already assigned to another person. Please find more issues here.

1 similar comment
Copy link

oss-gg bot commented Oct 12, 2024

This issue is already assigned to another person. Please find more issues here.

Copy link

oss-gg bot commented Oct 14, 2024

@priyanshu-kun, Just a little reminder: Please open a draft PR linking this issue within 12 hours. If we can't detect a PR in 12h, you will be unassigned automatically.

@charlesBochet
Copy link
Member

/unassign

Copy link

oss-gg bot commented Oct 14, 2024

Issue unassigned.

@rashap224
Copy link

/assign

Copy link

oss-gg bot commented Oct 14, 2024

Assigned to @rashap224! Please open a draft PR linking this issue within 48h ⚠️ If we can't detect a PR from you linking this issue in 48h, you'll be unassigned automatically 🕹️ Excited to have you ship this 🚀

@rashap224
Copy link

Hi @thomtrp Can you explain a bit about this issue. I am curious to know and work on it.

Copy link

oss-gg bot commented Oct 16, 2024

@priyanshu-kun, Just a little reminder: Please open a draft PR linking this issue within 12 hours. If we can't detect a PR in 12h, you will be unassigned automatically.

Copy link

oss-gg bot commented Oct 16, 2024

@rashap224, Just a little reminder: Please open a draft PR linking this issue within 12 hours. If we can't detect a PR in 12h, you will be unassigned automatically.

@charlesBochet
Copy link
Member

/unassign

Copy link

oss-gg bot commented Oct 17, 2024

Issue unassigned.

@oss-gg oss-gg bot unassigned rashap224 Oct 17, 2024
@Khaan25
Copy link
Contributor

Khaan25 commented Oct 18, 2024

Hey @charlesBochet, Can I work on this?

@charlesBochet
Copy link
Member

sure

@Khaan25
Copy link
Contributor

Khaan25 commented Oct 20, 2024

Hey @charlesBochet, I've created story and only imported the component to see but I'm getting this error? Do we've some providers to wrap around the story in decorators?
image

@FelixMalfait
Copy link
Member

From @charlesBochet on the PR:

I have taken a close look, looks like the ObjectFilterDropdownOptionSelect component is coupled with many things: 4 recoil states + parent dropdown + selectableList + object filter dropdown. Which is typical from an internal component that is not meant to be used of its context.

Because of that, I don't think it makes a lot of sense to test it as a standalone.

Instead, we should add more cases (including the Select field type here) to multiplefiltersdropdownbutton story

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers prio: low scope: front Issues that are affecting the frontend side only size: short type: chore
Projects
Status: 🆕 New
Development

Successfully merging a pull request may close this issue.