-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add storybook tests on ObjectFilterDropdownOptionSelect #4316
Comments
Hi @thomtrp I took a look the folders, none of the components in packages/twenty-front/src/modules/object-record/object-filter-dropdown/components have a story, ideally when we create a new component we should write the respective story too? |
I'm going to work on this issue. |
I will be working on this issue as well. |
Hello @thomtrp,
|
@BalanaguYashwanth Thanks for checking, I have renamed the issue |
/oss.gg 150 |
Thanks for opening an issue! It's live on oss.gg! |
/assign |
Assigned to @priyanshu-kun! Please open a draft PR linking this issue within 48h |
/assign |
This issue is already assigned to another person. Please find more issues here. |
/assign |
This issue is already assigned to another person. Please find more issues here. |
@priyanshu-kun, Just a little reminder: Please open a draft PR linking this issue within 12 hours. If we can't detect a PR in 12h, you will be unassigned automatically. |
/assign |
This issue is already assigned to another person. Please find more issues here. |
1 similar comment
This issue is already assigned to another person. Please find more issues here. |
@priyanshu-kun, Just a little reminder: Please open a draft PR linking this issue within 12 hours. If we can't detect a PR in 12h, you will be unassigned automatically. |
/unassign |
Issue unassigned. |
/assign |
Assigned to @rashap224! Please open a draft PR linking this issue within 48h |
Hi @thomtrp Can you explain a bit about this issue. I am curious to know and work on it. |
@priyanshu-kun, Just a little reminder: Please open a draft PR linking this issue within 12 hours. If we can't detect a PR in 12h, you will be unassigned automatically. |
@rashap224, Just a little reminder: Please open a draft PR linking this issue within 12 hours. If we can't detect a PR in 12h, you will be unassigned automatically. |
/unassign |
Issue unassigned. |
Hey @charlesBochet, Can I work on this? |
sure |
Hey @charlesBochet, I've created story and only imported the component to see but I'm getting this error? Do we've some providers to wrap around the story in decorators? |
From @charlesBochet on the PR:
|
Scope & Context
Follow-up on this PR: #3656
New components have been added without any storybook test.
Technical inputs
File paths are the following:
The text was updated successfully, but these errors were encountered: