Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workspace sync metadata should compare fields and objects using unique identifier #3621

Closed
Weiko opened this issue Jan 25, 2024 · 2 comments · Fixed by #4373
Closed

Workspace sync metadata should compare fields and objects using unique identifier #3621

Weiko opened this issue Jan 25, 2024 · 2 comments · Fixed by #4373
Assignees
Labels
scope: backend Issues that are affecting the backend side only type: chore

Comments

@Weiko
Copy link
Member

Weiko commented Jan 25, 2024

Scope & Context

The current implementation of the sync compares objects and their fields in the DB with the standard object defined in the code. To do that and avoid any issue with the diff while maintaining the correct order, we map objects and fields with their names. However, because of that we can't easily rename them and the sync will interpret them as different entities.

Technical inputs

First improvement would be to introduce a new column: standardFieldId? The value will never change and will allow us to map standard fields with rows in DB even if they've been renamed.

cc @magrinj @charlesBochet

@Weiko
Copy link
Member Author

Weiko commented Jan 25, 2024

Same for SELECT options?

@Weiko Weiko moved this from 🆕 New to 📋 Backlog in 🎯 Roadmap & Sprints Jan 25, 2024
@magrinj magrinj moved this from 📋 Backlog to 🔖 Planned in 🎯 Roadmap & Sprints Jan 30, 2024
@magrinj magrinj added the scope: backend Issues that are affecting the backend side only label Feb 2, 2024
@charlesBochet
Copy link
Member

We have decided not to sync the SELECT options so it should not be useful!

@magrinj magrinj moved this from 🔖 Planned to 🏗 In progress in 🎯 Roadmap & Sprints Mar 7, 2024
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in 🎯 Roadmap & Sprints Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: backend Issues that are affecting the backend side only type: chore
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants