Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add title/tooltip on hover icons. #3393

Closed
seAfnan opened this issue Jan 12, 2024 · 9 comments
Closed

Add title/tooltip on hover icons. #3393

seAfnan opened this issue Jan 12, 2024 · 9 comments
Labels
good first issue Good for newcomers scope: front Issues that are affecting the frontend side only

Comments

@seAfnan
Copy link
Contributor

seAfnan commented Jan 12, 2024

Scope & Context

There should a title or nice tooltip on hover icons to clarify its purpose.

Current behavior

Now there is no title/tooltip when we hover over icons. They looks almost same and we don't know their purpose.

twenty-no-hover-icon

Expected behavior

There should be a nice tooltip like title on hover.

twenty-hover-icon

@FelixMalfait
Copy link
Member

Thanks!

Component that could eventually be useful: https://storybook.twenty.com/?path=/story/ui-display-tooltip-tooltip--default&args=place:left;noArrow:!true

cc @Bonapara for approval and guidance

@Bonapara
Copy link
Member

Bonapara commented Jan 12, 2024

Thanks @seAfnan!

Let's use the component Felix suggested:

Component that could eventually be useful: https://storybook.twenty.com/?path=/story/ui-display-tooltip-tooltip--default&args=place:left;noArrow:!true

Please adjust the tooltip to display at the top. This will ensure the associated value remains visible during hover. Set noArrow to true

@Bonapara Bonapara added good first issue Good for newcomers size: minutes scope: front Issues that are affecting the frontend side only and removed blocked: design needed This doesn't seem right labels Jan 12, 2024
@daallgeier
Copy link
Contributor

Preferably i'd also see the name of the field next to it especially when it's Empty.

Replacing the greyed out Empty with a greyed out Company for example seems more useful to me.

@seAfnan
Copy link
Contributor Author

seAfnan commented Jan 12, 2024

Thanks @seAfnan!

Let's use the component Felix suggested:

Component that could eventually be useful: https://storybook.twenty.com/?path=/story/ui-display-tooltip-tooltip--default&args=place:left;noArrow:!true

Please adjust the tooltip to display at the top. This will ensure the associated value remains visible during hover. Set noArrow to true

IconMap -> Location
IconMoneyBag -> Currency
IconCalender -> Established
IconLink -> Website/Blog
IconUsers -> Members/Employees
IconTarget -> (please suggest)
IconBrandLinkedin -> Linkedin
IconBrandX -> Twitter/X

I am working on this, please suggest the text to show on tooltip.

@FelixMalfait
Copy link
Member

thanks @seAfnan the tooltip label should come from the metadata framework, we don't want to hardcode it.
When the app is loaded initially the frontend does a request to the backend ObjectMetadataItems and retrieve the list of all objects/fields for the workspace. That metadata is then made available through the frontend

@FelixMalfait
Copy link
Member

@daallgeier good suggestion. @Bonapara is making the calls on design so leaving it to him to decide!

@Bonapara
Copy link
Member

@daallgeier, this is a great idea! The only thing is that it should only be implemented when the field label is hidden (to avoid duplicating the field name) such as under:

CleanShot 2024-01-12 at 14 50 07

But this is still a good idea that would especially be interesting for kanban cards:

CleanShot 2024-01-12 at 14 59 09

To help the understanding, I believe we should display the field name on the show page:

CleanShot 2024-01-12 at 14 50 50

This does not resolve the issue. We still want to display a tooltip over the field icon. It will be particularly useful on the Kanban board where the field name is hidden.

@daallgeier, I'm creating a new issue to tackle two things: 1. Switch the placeholder from Empty to Field name when no field name/label is shown, and 2. Making the field name visible by default on shows.

@Bonapara
Copy link
Member

Created #3406 to address this. Thanks @daallgeier for the idea 🙌

@FelixMalfait
Copy link
Member

Closing as this one is also being addressed by #3529. Thanks for the suggestion and implementation @seAfnan!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers scope: front Issues that are affecting the frontend side only
Projects
None yet
Development

No branches or pull requests

4 participants