Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Keyboard navigation on IconPicker #2746

Closed
charlesBochet opened this issue Nov 28, 2023 · 1 comment · Fixed by #2778 or #2908
Closed

Add Keyboard navigation on IconPicker #2746

charlesBochet opened this issue Nov 28, 2023 · 1 comment · Fixed by #2778 or #2908
Assignees

Comments

@charlesBochet
Copy link
Member

Scope & Context

Recently, we had introduced a re-usable SelectableList component which used in CommandMenu. It provides a simple way to track which item is selected with keyboard.
Right now it only support one dimension (arrow up and down) but we would like to:

  • extend it to be 2-dimensions
  • use it to add arrow selection on IconPicker

Current behavior

On the IconPicker, it is not possible to select an icon using the keyboard (arrow up, down, left, right)

Expected behavior

On the IconPicker, is is possible to select an icon using the keyboard

Technical inputs

  • Improve SelectableList API to support 2 dimensions selectableItemIds (string[] => string[][])
  • improve SelectableList API to pass the Hotkeyscope (right now we have hardcoded CommandMenu one)
  • use it within IconPicker
Copy link
Contributor

gitstart-app bot commented Nov 28, 2023

Here is the GitStart Ticket for this issue: https://clients.gitstart.com/twenty/5449/tickets/TWNTY-2746

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
2 participants