Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New object field - Step 2 - New field type: Currency #2330

Closed
2 tasks done
Tracked by #2323
Bonapara opened this issue Nov 2, 2023 · 3 comments
Closed
2 tasks done
Tracked by #2323

New object field - Step 2 - New field type: Currency #2330

Bonapara opened this issue Nov 2, 2023 · 3 comments
Assignees
@CoreTeamTwenty
Labels
scope: front Issues that are affecting the frontend side only type: feature

Comments

@Bonapara
Copy link
Member

Bonapara commented Nov 2, 2023 •
edited by thaisguigon
Loading

Desired behavior

CleanShot 2023-11-02 at 18 21 35@2x

The Unit pick list should enable people to choose between:

  1. United States dollar (USD)
  2. Euro (EUR)
  3. Japanese yen (JPY)
  4. British pound (GBP)
  5. Canadian dollar (CAD)
  6. Swiss franc (CHF)
  7. Chinese yuan (CNY)
  8. Hong Kong dollar (HKD)

Do not implement the uniqueness & required features yet.

If there are any existing records with this field, display the value of the first non-empty field. Otherwise, the preview value should be $2.000. (without space between the $ and the number behind)

Figma

image

https://www.figma.com/file/xt8O9mFeLl46C5InWwoMrN/Twenty?type=design&node-id=13884-61375&mode=design&t=avVSH5fvDzQPdLL9-11

Tasks
Preview Give feedback
  1. New object field - Step 2 - Add "Currency" field type and preview #2346
    scope: front type: feature
    thaisguigon
  2. New object field - Step 2 - Add Currency field unit select #2347
    scope: front type: feature
    thaisguigon
@Bonapara Bonapara added the scope: back+front Issues requiring full-stack knowledge label Nov 2, 2023
@Bonapara Bonapara mentioned this issue Nov 2, 2023
Closed
@thaisguigon thaisguigon changed the title New field type: Currency New object field - Step 2 - New field type: Currency Nov 3, 2023
@thaisguigon thaisguigon mentioned this issue Nov 3, 2023
Closed
@thaisguigon thaisguigon added type: feature scope: front Issues that are affecting the frontend side only and removed blocked: conflict/dependency scope: back+front Issues requiring full-stack knowledge labels Nov 10, 2023
This was referenced Nov 24, 2023
Closed
Closed
@FelixMalfait
Copy link
Member

We talked with @Bonapara and we realized that currency unit is at the field level. So design above for setting page is incorrect. And we will need a new design to change the unit at the field level

@FelixMalfait
Copy link
Member

Actually we discussed it again and we can keep "unit" but as a defaultValue for the field

@Bonapara Bonapara mentioned this issue Feb 21, 2024
Closed
@Bonapara
Copy link
Member Author

Replaced by #4122

@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in 🎯 Roadmap & Sprints Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@CoreTeamTwenty CoreTeamTwenty

Labels
scope: front Issues that are affecting the frontend side only type: feature
Projects
🎯 Roadmap & Sprints
Status: ✅ Done
Milestone
No milestone
Development

No branches or pull requests
4 participants
@thaisguigon @FelixMalfait @Bonapara @CoreTeamTwenty