Skip to content

Commit ffcdace

Browse files
2980-Fix: CommandGroup background (#2985)
* 2980-fix: CommandGroup background * Box Shadow fix * suggested color fixes * Fix related to design dicussion: add border + make everything background secondary --------- Co-authored-by: Charles Bochet <[email protected]>
1 parent 0f7ddd2 commit ffcdace

File tree

3 files changed

+19
-7
lines changed

3 files changed

+19
-7
lines changed

packages/twenty-front/src/modules/command-menu/components/CommandMenu.tsx

+5-4
Original file line numberDiff line numberDiff line change
@@ -27,9 +27,10 @@ import { CommandGroup } from './CommandGroup';
2727
import { CommandMenuItem } from './CommandMenuItem';
2828

2929
export const StyledDialog = styled.div`
30-
background: ${({ theme }) => theme.background.primary};
30+
background: ${({ theme }) => theme.background.secondary};
31+
border: 1px solid ${({ theme }) => theme.border.color.medium};
3132
border-radius: ${({ theme }) => theme.border.radius.md};
32-
box-shadow: ${({ theme }) => theme.boxShadow.strong};
33+
box-shadow: ${({ theme }) => theme.boxShadow.superHeavy};
3334
font-family: ${({ theme }) => theme.font.family};
3435
left: 50%;
3536
max-width: 640px;
@@ -44,9 +45,9 @@ export const StyledDialog = styled.div`
4445
`;
4546

4647
export const StyledInput = styled.input`
47-
background: ${({ theme }) => theme.background.primary};
48+
background: ${({ theme }) => theme.background.secondary};
4849
border: none;
49-
border-bottom: 1px solid ${({ theme }) => theme.border.color.light};
50+
border-bottom: 1px solid ${({ theme }) => theme.border.color.medium};
5051
border-radius: 0;
5152
color: ${({ theme }) => theme.font.color.primary};
5253
font-size: ${({ theme }) => theme.font.size.lg};

packages/twenty-front/src/modules/ui/navigation/menu-item/components/MenuItemCommand.tsx

+3-1
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,9 @@ const StyledMenuItemCommandContainer = styled.div<{ isSelected?: boolean }>`
3131
--vertical-padding: ${({ theme }) => theme.spacing(2)};
3232
align-items: center;
3333
background: ${({ isSelected, theme }) =>
34-
isSelected ? theme.background.transparent.light : theme.background.primary};
34+
isSelected
35+
? theme.background.transparent.light
36+
: theme.background.secondary};
3537
border-radius: ${({ theme }) => theme.border.radius.sm};
3638
color: ${({ theme }) => theme.font.color.secondary};
3739
cursor: pointer;

packages/twenty-front/src/modules/ui/theme/constants/boxShadow.ts

+11-2
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
import { grayScale, rgba } from './colors';
22

33
export const boxShadowLight = {
4-
extraLight: `0px 1px 0px 0px ${rgba(grayScale.gray100, 0.04)}`,
54
light: `0px 2px 4px 0px ${rgba(
65
grayScale.gray100,
76
0.04,
@@ -11,10 +10,16 @@ export const boxShadowLight = {
1110
0.12,
1211
)}, 0px 2px 4px 0px ${rgba(grayScale.gray100, 0.04)}`,
1312
underline: `0px 1px 0px 0px ${rgba(grayScale.gray100, 0.32)}`,
13+
superHeavy: `0px 0px 8px 0px ${rgba(
14+
grayScale.gray100,
15+
0.16,
16+
)}, 0px 8px 64px -16px ${rgba(
17+
grayScale.gray100,
18+
0.48,
19+
)}, 0px 24px 56px -16px ${rgba(grayScale.gray100, 0.08)}`,
1420
};
1521

1622
export const boxShadowDark = {
17-
extraLight: `0px 1px 0px 0px ${rgba(grayScale.gray100, 0.04)}`,
1823
light: `0px 2px 4px 0px ${rgba(
1924
grayScale.gray100,
2025
0.04,
@@ -24,4 +29,8 @@ export const boxShadowDark = {
2429
0.16,
2530
)}, 0px 2px 4px 0px ${rgba(grayScale.gray100, 0.08)}`,
2631
underline: `0px 1px 0px 0px ${rgba(grayScale.gray100, 0.32)}`,
32+
superHeavy: `2px 4px 16px 0px ${rgba(
33+
grayScale.gray100,
34+
0.12,
35+
)}, 0px 2px 4px 0px ${rgba(grayScale.gray100, 0.04)}`,
2736
};

0 commit comments

Comments
 (0)