From b80fa9cf1398a3f0f6f34465d3dfe89109103b51 Mon Sep 17 00:00:00 2001
From: Marie <51697796+ijreilly@users.noreply.github.com>
Date: Wed, 9 Oct 2024 17:03:28 +0200
Subject: [PATCH] Fix seeds (#7543)

- Fixing seeds after introducing the requirement for non-nullable fields
to have a default value (https://github.com/twentyhq/twenty/pull/7522).
- Empty string needs to be considered a valid default value
---
 .../src/database/typeorm-seeds/metadata/fieldsMetadata.ts | 8 ++++++++
 .../field-metadata/field-metadata.service.ts              | 3 ++-
 2 files changed, 10 insertions(+), 1 deletion(-)

diff --git a/packages/twenty-server/src/database/typeorm-seeds/metadata/fieldsMetadata.ts b/packages/twenty-server/src/database/typeorm-seeds/metadata/fieldsMetadata.ts
index cf605a51244e..5f0f8219c8f3 100644
--- a/packages/twenty-server/src/database/typeorm-seeds/metadata/fieldsMetadata.ts
+++ b/packages/twenty-server/src/database/typeorm-seeds/metadata/fieldsMetadata.ts
@@ -15,6 +15,7 @@ export const getDevSeedCompanyCustomFields = (
       icon: 'IconAdCircle',
       isActive: true,
       isNullable: false,
+      defaultValue: "''",
       objectMetadataId,
     },
     {
@@ -99,6 +100,13 @@ export const getDevSeedPeopleCustomFields = (
       icon: 'IconBrandWhatsapp',
       isActive: true,
       isNullable: false,
+      defaultValue: [
+        {
+          primaryPhoneNumber: '',
+          primaryPhoneCountryCode: '',
+          additionalPhones: {},
+        },
+      ],
       objectMetadataId,
     },
     {
diff --git a/packages/twenty-server/src/engine/metadata-modules/field-metadata/field-metadata.service.ts b/packages/twenty-server/src/engine/metadata-modules/field-metadata/field-metadata.service.ts
index 924e9ff1bc8c..8ea3b656d8d6 100644
--- a/packages/twenty-server/src/engine/metadata-modules/field-metadata/field-metadata.service.ts
+++ b/packages/twenty-server/src/engine/metadata-modules/field-metadata/field-metadata.service.ts
@@ -55,6 +55,7 @@ import { TwentyORMGlobalManager } from 'src/engine/twenty-orm/twenty-orm-global.
 import { computeObjectTargetTable } from 'src/engine/utils/compute-object-target-table.util';
 import { WorkspaceMigrationRunnerService } from 'src/engine/workspace-manager/workspace-migration-runner/workspace-migration-runner.service';
 import { ViewFieldWorkspaceEntity } from 'src/modules/view/standard-objects/view-field.workspace-entity';
+import { isDefined } from 'src/utils/is-defined';
 
 import { FieldMetadataValidationService } from './field-metadata-validation.service';
 import {
@@ -746,7 +747,7 @@ export class FieldMetadataService extends TypeOrmQueryService<FieldMetadataEntit
     }
 
     if (!fieldMetadataInput.isNullable) {
-      if (!fieldMetadataInput.defaultValue) {
+      if (!isDefined(fieldMetadataInput.defaultValue)) {
         throw new FieldMetadataException(
           'Default value is required for non nullable fields',
           FieldMetadataExceptionCode.INVALID_FIELD_INPUT,