Remove unused async

Author: thomtrp

packages/twenty-front/src/modules/navigation/hooks/useObjectMetadataItemsInWorkspaceFavorites.ts

@@ -13,17 +13,19 @@ export const useObjectMetadataItemsInWorkspaceFavorites = () => {
     workspaceFavorites.map((favorite) => favorite.recordId),
   );
 
-  const favoriteViewObjectMetadataIds = views.reduce<string[]>((acc, view) => {
-    if (workspaceFavoriteIds.has(view.id)) {
-      acc.push(view.objectMetadataId);
-    }
-    return acc;
-  }, []);
+  const favoriteViewObjectMetadataIds = new Set(
+    views.reduce<string[]>((acc, view) => {
+      if (workspaceFavoriteIds.has(view.id)) {
+        acc.push(view.objectMetadataId);
+      }
+      return acc;
+    }, []),
+  );
 
   const { objectMetadataItems } = useFilteredObjectMetadataItems();
 
   const objectMetadataItemsInWorkspaceFavorites = objectMetadataItems.filter(
-    (item) => favoriteViewObjectMetadataIds.includes(item.id),
+    (item) => favoriteViewObjectMetadataIds.has(item.id),
   );
 
   return {

packages/twenty-server/src/engine/workspace-manager/standard-objects-prefill-data/view.ts

@@ -20,18 +20,18 @@ export const viewPrefillData = async (
   isWorkflowEnabled: boolean,
 ) => {
   const viewDefinitions = [
-    await companiesAllView(objectMetadataMap),
-    await peopleAllView(objectMetadataMap),
-    await opportunitiesAllView(objectMetadataMap),
-    await opportunitiesByStageView(objectMetadataMap),
-    await notesAllView(objectMetadataMap),
-    await tasksAllView(objectMetadataMap),
-    await tasksByStatusView(objectMetadataMap),
+    companiesAllView(objectMetadataMap),
+    peopleAllView(objectMetadataMap),
+    opportunitiesAllView(objectMetadataMap),
+    opportunitiesByStageView(objectMetadataMap),
+    notesAllView(objectMetadataMap),
+    tasksAllView(objectMetadataMap),
+    tasksByStatusView(objectMetadataMap),
     ...(isWorkflowEnabled
       ? [
-          await workflowsAllView(objectMetadataMap),
-          await workflowVersionsAllView(objectMetadataMap),
-          await workflowRunsAllView(objectMetadataMap),
+          workflowsAllView(objectMetadataMap),
+          workflowVersionsAllView(objectMetadataMap),
+          workflowRunsAllView(objectMetadataMap),
         ]
       : []),
   ];

packages/twenty-server/src/engine/workspace-manager/standard-objects-prefill-data/views/companies-all.view.ts

@@ -5,7 +5,7 @@ import {
 } from 'src/engine/workspace-manager/workspace-sync-metadata/constants/standard-field-ids';
 import { STANDARD_OBJECT_IDS } from 'src/engine/workspace-manager/workspace-sync-metadata/constants/standard-object-ids';
 
-export const companiesAllView = async (
+export const companiesAllView = (
   objectMetadataMap: Record<string, ObjectMetadataEntity>,
 ) => {
   return {

packages/twenty-server/src/engine/workspace-manager/standard-objects-prefill-data/views/notes-all.view.ts

@@ -5,7 +5,7 @@ import {
 } from 'src/engine/workspace-manager/workspace-sync-metadata/constants/standard-field-ids';
 import { STANDARD_OBJECT_IDS } from 'src/engine/workspace-manager/workspace-sync-metadata/constants/standard-object-ids';
 
-export const notesAllView = async (
+export const notesAllView = (
   objectMetadataMap: Record<string, ObjectMetadataEntity>,
 ) => {
   return {

packages/twenty-server/src/engine/workspace-manager/standard-objects-prefill-data/views/opportunities-all.view.ts

@@ -2,7 +2,7 @@ import { ObjectMetadataEntity } from 'src/engine/metadata-modules/object-metadat
 import { OPPORTUNITY_STANDARD_FIELD_IDS } from 'src/engine/workspace-manager/workspace-sync-metadata/constants/standard-field-ids';
 import { STANDARD_OBJECT_IDS } from 'src/engine/workspace-manager/workspace-sync-metadata/constants/standard-object-ids';
 
-export const opportunitiesAllView = async (
+export const opportunitiesAllView = (
   objectMetadataMap: Record<string, ObjectMetadataEntity>,
 ) => {
   return {

packages/twenty-server/src/engine/workspace-manager/standard-objects-prefill-data/views/opportunity-by-stage.view.ts

@@ -2,7 +2,7 @@ import { ObjectMetadataEntity } from 'src/engine/metadata-modules/object-metadat
 import { OPPORTUNITY_STANDARD_FIELD_IDS } from 'src/engine/workspace-manager/workspace-sync-metadata/constants/standard-field-ids';
 import { STANDARD_OBJECT_IDS } from 'src/engine/workspace-manager/workspace-sync-metadata/constants/standard-object-ids';
 
-export const opportunitiesByStageView = async (
+export const opportunitiesByStageView = (
   objectMetadataMap: Record<string, ObjectMetadataEntity>,
 ) => {
   return {

packages/twenty-server/src/engine/workspace-manager/standard-objects-prefill-data/views/people-all.view.ts

@@ -5,7 +5,7 @@ import {
 } from 'src/engine/workspace-manager/workspace-sync-metadata/constants/standard-field-ids';
 import { STANDARD_OBJECT_IDS } from 'src/engine/workspace-manager/workspace-sync-metadata/constants/standard-object-ids';
 
-export const peopleAllView = async (
+export const peopleAllView = (
   objectMetadataMap: Record<string, ObjectMetadataEntity>,
 ) => {
   return {

packages/twenty-server/src/engine/workspace-manager/standard-objects-prefill-data/views/tasks-all.view.ts

@@ -5,7 +5,7 @@ import {
 } from 'src/engine/workspace-manager/workspace-sync-metadata/constants/standard-field-ids';
 import { STANDARD_OBJECT_IDS } from 'src/engine/workspace-manager/workspace-sync-metadata/constants/standard-object-ids';
 
-export const tasksAllView = async (
+export const tasksAllView = (
   objectMetadataMap: Record<string, ObjectMetadataEntity>,
 ) => {
   return {

packages/twenty-server/src/engine/workspace-manager/standard-objects-prefill-data/views/tasks-by-status.view.ts

@@ -5,7 +5,7 @@ import {
 } from 'src/engine/workspace-manager/workspace-sync-metadata/constants/standard-field-ids';
 import { STANDARD_OBJECT_IDS } from 'src/engine/workspace-manager/workspace-sync-metadata/constants/standard-object-ids';
 
-export const tasksByStatusView = async (
+export const tasksByStatusView = (
   objectMetadataMap: Record<string, ObjectMetadataEntity>,
 ) => {
   return {

packages/twenty-server/src/engine/workspace-manager/standard-objects-prefill-data/views/workflow-runs-all.view.ts

@@ -2,7 +2,7 @@ import { ObjectMetadataEntity } from 'src/engine/metadata-modules/object-metadat
 import { WORKFLOW_RUN_STANDARD_FIELD_IDS } from 'src/engine/workspace-manager/workspace-sync-metadata/constants/standard-field-ids';
 import { STANDARD_OBJECT_IDS } from 'src/engine/workspace-manager/workspace-sync-metadata/constants/standard-object-ids';
 
-export const workflowRunsAllView = async (
+export const workflowRunsAllView = (
   objectMetadataMap: Record<string, ObjectMetadataEntity>,
 ) => {
   return {

packages/twenty-server/src/engine/workspace-manager/standard-objects-prefill-data/views/workflow-versions.view.ts

@@ -2,7 +2,7 @@ import { ObjectMetadataEntity } from 'src/engine/metadata-modules/object-metadat
 import { WORKFLOW_VERSION_STANDARD_FIELD_IDS } from 'src/engine/workspace-manager/workspace-sync-metadata/constants/standard-field-ids';
 import { STANDARD_OBJECT_IDS } from 'src/engine/workspace-manager/workspace-sync-metadata/constants/standard-object-ids';
 
-export const workflowVersionsAllView = async (
+export const workflowVersionsAllView = (
   objectMetadataMap: Record<string, ObjectMetadataEntity>,
 ) => {
   return {

packages/twenty-server/src/engine/workspace-manager/standard-objects-prefill-data/views/workflows-all.view.ts

@@ -2,7 +2,7 @@ import { ObjectMetadataEntity } from 'src/engine/metadata-modules/object-metadat
 import { WORKFLOW_STANDARD_FIELD_IDS } from 'src/engine/workspace-manager/workspace-sync-metadata/constants/standard-field-ids';
 import { STANDARD_OBJECT_IDS } from 'src/engine/workspace-manager/workspace-sync-metadata/constants/standard-object-ids';
 
-export const workflowsAllView = async (
+export const workflowsAllView = (
   objectMetadataMap: Record<string, ObjectMetadataEntity>,
 ) => {
   return {