Add tests

Author: thomtrp

packages/twenty-server/src/engine/metadata-modules/remote-server/remote-table/distant-table/utils/__tests__/sort-distant-tables.spec.ts

@@ -1,5 +1,5 @@
 import { RemoteTableStatus } from 'src/engine/metadata-modules/remote-server/remote-table/dtos/remote-table.dto';
-import { distantTablesSorter } from 'src/engine/metadata-modules/remote-server/remote-table/distant-table/utils/sort-distant-tables.util';
+import { sortDistantTables } from 'src/engine/metadata-modules/remote-server/remote-table/distant-table/utils/sort-distant-tables.util';
 
 const table1 = {
   status: RemoteTableStatus.SYNCED,
@@ -13,19 +13,19 @@ const table2 = {
 
 describe('sortDistantTables', () => {
   it('should return -1 when first param status is SYNCED and second param status is NOT_SYNCED', () => {
-    const result = distantTablesSorter(table1, table2);
+    const result = sortDistantTables(table1, table2);
 
     expect(result).toBe(-1);
   });
 
   it('should return 1 when first param status is NOT_SYNCED and second param status is SYNCED', () => {
-    const result = distantTablesSorter(table2, table1);
+    const result = sortDistantTables(table2, table1);
 
     expect(result).toBe(1);
   });
 
   it('should return -1 when same status and first param name is smaller than second param name', () => {
-    const result = distantTablesSorter(
+    const result = sortDistantTables(
       { ...table1, status: RemoteTableStatus.NOT_SYNCED },
       table2,
     );
@@ -34,11 +34,20 @@ describe('sortDistantTables', () => {
   });
 
   it('should return 1 when same status and second param name is smaller than first param name', () => {
-    const result = distantTablesSorter(table2, {
+    const result = sortDistantTables(table2, {
       ...table1,
       status: RemoteTableStatus.NOT_SYNCED,
     });
 
     expect(result).toBe(1);
   });
+
+  it('should be case insensitive', () => {
+    const result = sortDistantTables(
+      { ...table1, name: 'table1', status: RemoteTableStatus.NOT_SYNCED },
+      { ...table2, name: 'Table2' },
+    );
+
+    expect(result).toBe(-1);
+  });
 });

packages/twenty-server/src/engine/metadata-modules/remote-server/remote-table/distant-table/utils/sort-distant-tables.util.ts

@@ -1,6 +1,15 @@
 import { RemoteTableStatus } from 'src/engine/metadata-modules/remote-server/remote-table/dtos/remote-table.dto';
 
-export const sortDistantTables = (table1, table2) => {
+export const sortDistantTables = (
+  table1: {
+    status: RemoteTableStatus;
+    name: string;
+  },
+  table2: {
+    status: RemoteTableStatus;
+    name: string;
+  },
+) => {
   if (
     table1.status === RemoteTableStatus.SYNCED &&
     table2.status === RemoteTableStatus.NOT_SYNCED
@@ -15,5 +24,5 @@ export const sortDistantTables = (table1, table2) => {
     return 1;
   }
 
-  return table1.name > table2.name ? 1 : -1;
+  return table1.name.toUpperCase() > table2.name.toUpperCase() ? 1 : -1;
 };