Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default value for extra_flags_per_feature CC configuration is invalid #578

Closed
Silic0nS0ldier opened this issue Aug 28, 2024 · 1 comment · Fixed by #576
Closed

Default value for extra_flags_per_feature CC configuration is invalid #578

Silic0nS0ldier opened this issue Aug 28, 2024 · 1 comment · Fixed by #576

Comments

@Silic0nS0ldier
Copy link
Contributor

Describe the bug
Bazel is expecting a dict ({}) but is given list ([]).

To Reproduce
Use a Nix CC toolchain in Bazel 7.3.0 or 8.0.0-pre.20240807.1.

Expected behavior
Build passes.

Environment

  • OS name + version: GNU/Linux (Ubuntu 22.04)
  • Version of the code: a11818b

Additional context
Issue manifests as

RROR: /[...]/external/local_config_cc_nix_x86_64-linux/BUILD.bazel:92:20: @@local_config_cc_nix_x86_64-linux//:local: expected value of type 'dict(string, list(string))' for attribute 'extra_flags_per_feature' in 'cc_toolchain_config' rule, but got [] (list)
ERROR: Evaluation of query "@local_config_cc_nix_x86_64-linux//:local" failed

Issue noted on #574, new issue raised as I cannot open the closed issue (and technically there is a value now).

@aherrmann
Copy link
Member

Will be addressed by #576

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants
@aherrmann @Silic0nS0ldier and others