Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove usage of @hackage as much as possible in tests #654

Closed
nmattia opened this issue Jan 29, 2019 · 3 comments
Closed

Remove usage of @hackage as much as possible in tests #654

nmattia opened this issue Jan 29, 2019 · 3 comments
Assignees

Comments

@nmattia
Copy link
Contributor

nmattia commented Jan 29, 2019

The @hackage repository (used for fetching prebuilt haskell libraries) is only available on Nix platforms. We should use it in tests only as little as necessary so that we can enable more tests for non-Nix platforms.

@mboes
Copy link
Member

mboes commented Jan 29, 2019

I believe this is already the case since #615. What is left to be done?

@nmattia
Copy link
Contributor Author

nmattia commented Jan 29, 2019

Among others:

"@hackage//:process",

@picnoir
Copy link
Contributor

picnoir commented Jan 29, 2019

I tagged the rules using hackage with requires_hackage.

After fixing this, we will be able to remove the corresponding flag in the circleci config: https://github.com/tweag/rules_haskell/blob/master/.circleci/config.yml#L18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants