Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

haskell.build should be deployed from last release instead of current master #1020

Closed
Profpatsch opened this issue Jul 30, 2019 · 5 comments
Closed
Labels
P1 critical: next release type: bug

Comments

@Profpatsch
Copy link
Contributor

Describe the bug

Building from release has two implications:

  • The start script will refer to the one on current master, meaning if there were breaking changes it will fail with the last release.
  • The docs document master instead of the release people are using.

Expected behavior

https://haskell.build should only be updated once per release.

Optionally, we should have a second subdomain https://master.api.haskell.build/, which points to the current master documentation.

@Profpatsch
Copy link
Contributor Author

I opened another issue in the past that is a subset of this one: #857

@Profpatsch
Copy link
Contributor Author

Profpatsch commented Jul 31, 2019

We use netlify for deployment, and netlify supports creating subdomains for branches, iff the netlify DNS setup is used: https://www.netlify.com/docs/custom-domains/#branch-subdomains

I suggest we do the following (if possible, or similar):

  • Point master to master.api.build.haskell, push with every branch update.
  • Create a release branch and point it to release.api.build.haskell.
    • Add “push release branch to release tag” to the MAINTAINERS manual for creating a release
  • Change the frontpage at https://haskell.build/ to point to both the master API documentation and the latest release (preferring the latest release).

I don’t have access to the netlify setup, @mboes could you take a look to see if that is possible?

@mboes
Copy link
Member

mboes commented Aug 10, 2019

We can't use that because we don't use Netlify for the DNS. We use CloudFlare I believe.

@mboes mboes added the P1 critical: next release label Aug 10, 2019
@mboes
Copy link
Member

mboes commented Aug 10, 2019

OK we now have two branches, with branch subdomains:

  • master.api.haskell.build
  • release.api.haskell.build

@mboes
Copy link
Member

mboes commented Aug 11, 2019

Buttons to each site added to front page.

@mboes mboes closed this as completed Aug 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 critical: next release type: bug
Projects
None yet
Development

No branches or pull requests

2 participants