diff --git a/README.md b/README.md index 5989a31f..c018aae3 100644 --- a/README.md +++ b/README.md @@ -169,16 +169,6 @@ Therefore, we recommend you keep this nuget package as up to date as possible us For more information on metadata usage, please refer to the [main repository faq](https://github.com/google/libphonenumber/blob/master/FAQ.md#metadata) -## ToDo - -* update / add / port new unit tests and logging from java source - -## How to unfold automatic generated files - -* Install Jetbrains - Resharper for Visual Studio -* File by file, right click and "Cleanup code" -* Check the unfolded file - ## Running tests locally ```bash diff --git a/csharp/README.md b/csharp/README.md index 9c98b8b6..56e28ff5 100644 --- a/csharp/README.md +++ b/csharp/README.md @@ -44,9 +44,9 @@ Known Issues and embedded in the assembly. No zip files or text files are needed to run the library or its tests. - -Todo ----- - -- Restore the Java logging calls? -- Find a suitable replace for Java CharSequence in phone numbers parsing API. +- Java's public API accepts `CharSequence` in several entry points (e.g. + `PhoneNumberMatcher`'s constructor, `isViablePhoneNumber`), letting callers pass a `String`, + `StringBuilder`, or `StringBuffer` without copying. The C# port takes `string` in the + equivalent spots (`PhoneNumberMatcher(PhoneNumberUtil, string, ...)`, + `PhoneNumberUtil.IsViablePhoneNumber(string)`) instead of a comparable abstraction, so a + caller building up a number in a `StringBuilder` has to call `.ToString()` first.