Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The documentation for tabs is not accurate #10282

Closed
jacob-carlborg opened this issue Aug 29, 2013 · 4 comments
Closed

The documentation for tabs is not accurate #10282

jacob-carlborg opened this issue Aug 29, 2013 · 4 comments

Comments

@jacob-carlborg
Copy link

The documentation for tabs fails to mention that when the class fade is used on the tab items (.tab-pane), it's required to include the "tab.js" file.

@cvrebert
Copy link
Collaborator

We should probably add cross-references between components and their optional JS plugins (in cases where such plugins exist).

@jacob-carlborg
Copy link
Author

The documentation for 2.3.2 mentions tab.js but not transition.js.

@mdo mdo closed this as completed in 129d8fc Sep 1, 2013
@mdo
Copy link
Member

mdo commented Sep 1, 2013

If this is a problem in 2.3.2, we're not fixing it. The docs for v3 looks fine for this problem (we mention the fade effect explicitly in the JS docs), though we should address @cvrebert's point.

@mdo mdo mentioned this issue Sep 1, 2013
@jacob-carlborg
Copy link
Author

The docs for v3 looks fine for this problem (we mention the fade effect explicitly in the JS docs)

Where, I can't find it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants