Skip to content

Commit c553290

Browse files
patrickhlaukepatrickhlauke
committed
Revert "Leave tabindex=-1 alone"
This reverts commit 370fa45.
1 parent 370fa45 commit c553290

File tree

2 files changed

+64
-64
lines changed

2 files changed

+64
-64
lines changed

‎docs/components.html

+40-40
Original file line numberDiff line numberDiff line change
@@ -118,21 +118,21 @@ <h2>Example</h2>
118118
<div class="bs-docs-example">
119119
<div class="dropdown clearfix">
120120
<ul class="dropdown-menu" role="menu" aria-labelledby="dropdownMenu" style="display: block; position: static; margin-bottom: 5px; *width: 180px;">
121-
<li><a href="#">Action</a></li>
122-
<li><a href="#">Another action</a></li>
123-
<li><a href="#">Something else here</a></li>
121+
<li><a tabindex="-1" href="#">Action</a></li>
122+
<li><a tabindex="-1" href="#">Another action</a></li>
123+
<li><a tabindex="-1" href="#">Something else here</a></li>
124124
<li class="divider"></li>
125-
<li><a href="#">Separated link</a></li>
125+
<li><a tabindex="-1" href="#">Separated link</a></li>
126126
</ul>
127127
</div>
128128
</div>
129129
<pre class="prettyprint linenums">
130130
&lt;ul class="dropdown-menu" role="menu" aria-labelledby="dropdownMenu"&gt;
131-
&lt;li&gt;&lt;a href="#"&gt;Action&lt;/a&gt;&lt;/li&gt;
132-
&lt;li&gt;&lt;a href="#"&gt;Another action&lt;/a&gt;&lt;/li&gt;
133-
&lt;li&gt;&lt;a href="#"&gt;Something else here&lt;/a&gt;&lt;/li&gt;
131+
&lt;li&gt;&lt;a tabindex="-1" href="#"&gt;Action&lt;/a&gt;&lt;/li&gt;
132+
&lt;li&gt;&lt;a tabindex="-1" href="#"&gt;Another action&lt;/a&gt;&lt;/li&gt;
133+
&lt;li&gt;&lt;a tabindex="-1" href="#"&gt;Something else here&lt;/a&gt;&lt;/li&gt;
134134
&lt;li class="divider"&gt;&lt;/li&gt;
135-
&lt;li&gt;&lt;a href="#"&gt;Separated link&lt;/a&gt;&lt;/li&gt;
135+
&lt;li&gt;&lt;a tabindex="-1" href="#"&gt;Separated link&lt;/a&gt;&lt;/li&gt;
136136
&lt;/ul&gt;
137137
</pre>
138138

@@ -143,11 +143,11 @@ <h2>Markup</h2>
143143
&lt;div class="dropdown"&gt;
144144
&lt;!-- Link or button to toggle dropdown --&gt;
145145
&lt;ul class="dropdown-menu" role="menu" aria-labelledby="dLabel"&gt;
146-
&lt;li&gt;&lt;a href="#"&gt;Action&lt;/a&gt;&lt;/li&gt;
147-
&lt;li&gt;&lt;a href="#"&gt;Another action&lt;/a&gt;&lt;/li&gt;
148-
&lt;li&gt;&lt;a href="#"&gt;Something else here&lt;/a&gt;&lt;/li&gt;
146+
&lt;li&gt;&lt;a tabindex="-1" href="#"&gt;Action&lt;/a&gt;&lt;/li&gt;
147+
&lt;li&gt;&lt;a tabindex="-1" href="#"&gt;Another action&lt;/a&gt;&lt;/li&gt;
148+
&lt;li&gt;&lt;a tabindex="-1" href="#"&gt;Something else here&lt;/a&gt;&lt;/li&gt;
149149
&lt;li class="divider"&gt;&lt;/li&gt;
150-
&lt;li&gt;&lt;a href="#"&gt;Separated link&lt;/a&gt;&lt;/li&gt;
150+
&lt;li&gt;&lt;a tabindex="-1" href="#"&gt;Separated link&lt;/a&gt;&lt;/li&gt;
151151
&lt;/ul&gt;
152152
&lt;/div&gt;
153153
</pre>
@@ -171,18 +171,18 @@ <h3>Sub menus on dropdowns</h3>
171171
<p class="muted">Default</p>
172172
<div class="dropdown clearfix">
173173
<ul class="dropdown-menu" role="menu" aria-labelledby="dropdownMenu">
174-
<li><a href="#">Action</a></li>
175-
<li><a href="#">Another action</a></li>
176-
<li><a href="#">Something else here</a></li>
174+
<li><a tabindex="-1" href="#">Action</a></li>
175+
<li><a tabindex="-1" href="#">Another action</a></li>
176+
<li><a tabindex="-1" href="#">Something else here</a></li>
177177
<li class="divider"></li>
178178
<li class="dropdown-submenu">
179-
<a href="#">More options</a>
179+
<a tabindex="-1" href="#">More options</a>
180180
<ul class="dropdown-menu">
181-
<li><a href="#">Second level link</a></li>
182-
<li><a href="#">Second level link</a></li>
183-
<li><a href="#">Second level link</a></li>
184-
<li><a href="#">Second level link</a></li>
185-
<li><a href="#">Second level link</a></li>
181+
<li><a tabindex="-1" href="#">Second level link</a></li>
182+
<li><a tabindex="-1" href="#">Second level link</a></li>
183+
<li><a tabindex="-1" href="#">Second level link</a></li>
184+
<li><a tabindex="-1" href="#">Second level link</a></li>
185+
<li><a tabindex="-1" href="#">Second level link</a></li>
186186
</ul>
187187
</li>
188188
</ul>
@@ -193,18 +193,18 @@ <h3>Sub menus on dropdowns</h3>
193193
<p class="muted">Dropup</p>
194194
<div class="dropup">
195195
<ul class="dropdown-menu" role="menu" aria-labelledby="dropdownMenu">
196-
<li><a href="#">Action</a></li>
197-
<li><a href="#">Another action</a></li>
198-
<li><a href="#">Something else here</a></li>
196+
<li><a tabindex="-1" href="#">Action</a></li>
197+
<li><a tabindex="-1" href="#">Another action</a></li>
198+
<li><a tabindex="-1" href="#">Something else here</a></li>
199199
<li class="divider"></li>
200200
<li class="dropdown-submenu">
201-
<a href="#">More options</a>
201+
<a tabindex="-1" href="#">More options</a>
202202
<ul class="dropdown-menu">
203-
<li><a href="#">Second level link</a></li>
204-
<li><a href="#">Second level link</a></li>
205-
<li><a href="#">Second level link</a></li>
206-
<li><a href="#">Second level link</a></li>
207-
<li><a href="#">Second level link</a></li>
203+
<li><a tabindex="-1" href="#">Second level link</a></li>
204+
<li><a tabindex="-1" href="#">Second level link</a></li>
205+
<li><a tabindex="-1" href="#">Second level link</a></li>
206+
<li><a tabindex="-1" href="#">Second level link</a></li>
207+
<li><a tabindex="-1" href="#">Second level link</a></li>
208208
</ul>
209209
</li>
210210
</ul>
@@ -215,18 +215,18 @@ <h3>Sub menus on dropdowns</h3>
215215
<p class="muted">Left submenu</p>
216216
<div class="dropdown">
217217
<ul class="dropdown-menu" role="menu" aria-labelledby="dropdownMenu">
218-
<li><a href="#">Action</a></li>
219-
<li><a href="#">Another action</a></li>
220-
<li><a href="#">Something else here</a></li>
218+
<li><a tabindex="-1" href="#">Action</a></li>
219+
<li><a tabindex="-1" href="#">Another action</a></li>
220+
<li><a tabindex="-1" href="#">Something else here</a></li>
221221
<li class="divider"></li>
222222
<li class="dropdown-submenu pull-left">
223-
<a href="#">More options</a>
223+
<a tabindex="-1" href="#">More options</a>
224224
<ul class="dropdown-menu">
225-
<li><a href="#">Second level link</a></li>
226-
<li><a href="#">Second level link</a></li>
227-
<li><a href="#">Second level link</a></li>
228-
<li><a href="#">Second level link</a></li>
229-
<li><a href="#">Second level link</a></li>
225+
<li><a tabindex="-1" href="#">Second level link</a></li>
226+
<li><a tabindex="-1" href="#">Second level link</a></li>
227+
<li><a tabindex="-1" href="#">Second level link</a></li>
228+
<li><a tabindex="-1" href="#">Second level link</a></li>
229+
<li><a tabindex="-1" href="#">Second level link</a></li>
230230
</ul>
231231
</li>
232232
</ul>
@@ -238,7 +238,7 @@ <h3>Sub menus on dropdowns</h3>
238238
&lt;ul class="dropdown-menu" role="menu" aria-labelledby="dLabel"&gt;
239239
...
240240
&lt;li class="dropdown-submenu"&gt;
241-
&lt;a href="#"&gt;More options&lt;/a&gt;
241+
&lt;a tabindex="-1" href="#"&gt;More options&lt;/a&gt;
242242
&lt;ul class="dropdown-menu"&gt;
243243
...
244244
&lt;/ul&gt;

‎docs/javascript.html

+24-24
Original file line numberDiff line numberDiff line change
@@ -405,33 +405,33 @@ <h3>Within a navbar</h3>
405405
<li class="dropdown">
406406
<a id="drop1" href="#" role="button" class="dropdown-toggle" data-toggle="dropdown">Dropdown <b class="caret"></b></a>
407407
<ul class="dropdown-menu" role="menu" aria-labelledby="drop1">
408-
<li role="presentation"><a role="menuitem" href="http://google.com">Action</a></li>
409-
<li role="presentation"><a role="menuitem" href="#anotherAction">Another action</a></li>
410-
<li role="presentation"><a role="menuitem" href="#">Something else here</a></li>
408+
<li role="presentation"><a role="menuitem" tabindex="-1" href="http://google.com">Action</a></li>
409+
<li role="presentation"><a role="menuitem" tabindex="-1" href="#anotherAction">Another action</a></li>
410+
<li role="presentation"><a role="menuitem" tabindex="-1" href="#">Something else here</a></li>
411411
<li role="presentation" class="divider"></li>
412-
<li role="presentation"><a role="menuitem" href="#">Separated link</a></li>
412+
<li role="presentation"><a role="menuitem" tabindex="-1" href="#">Separated link</a></li>
413413
</ul>
414414
</li>
415415
<li class="dropdown">
416416
<a href="#" id="drop2" role="button" class="dropdown-toggle" data-toggle="dropdown">Dropdown 2 <b class="caret"></b></a>
417417
<ul class="dropdown-menu" role="menu" aria-labelledby="drop2">
418-
<li role="presentation"><a role="menuitem" href="#">Action</a></li>
419-
<li role="presentation"><a role="menuitem" href="#">Another action</a></li>
420-
<li role="presentation"><a role="menuitem" href="#">Something else here</a></li>
418+
<li role="presentation"><a role="menuitem" tabindex="-1" href="#">Action</a></li>
419+
<li role="presentation"><a role="menuitem" tabindex="-1" href="#">Another action</a></li>
420+
<li role="presentation"><a role="menuitem" tabindex="-1" href="#">Something else here</a></li>
421421
<li role="presentation" class="divider"></li>
422-
<li role="presentation"><a role="menuitem" href="#">Separated link</a></li>
422+
<li role="presentation"><a role="menuitem" tabindex="-1" href="#">Separated link</a></li>
423423
</ul>
424424
</li>
425425
</ul>
426426
<ul class="nav pull-right">
427427
<li id="fat-menu" class="dropdown">
428428
<a href="#" id="drop3" role="button" class="dropdown-toggle" data-toggle="dropdown">Dropdown 3 <b class="caret"></b></a>
429429
<ul class="dropdown-menu" role="menu" aria-labelledby="drop3">
430-
<li role="presentation"><a role="menuitem" href="#">Action</a></li>
431-
<li role="presentation"><a role="menuitem" href="#">Another action</a></li>
432-
<li role="presentation"><a role="menuitem" href="#">Something else here</a></li>
430+
<li role="presentation"><a role="menuitem" tabindex="-1" href="#">Action</a></li>
431+
<li role="presentation"><a role="menuitem" tabindex="-1" href="#">Another action</a></li>
432+
<li role="presentation"><a role="menuitem" tabindex="-1" href="#">Something else here</a></li>
433433
<li role="presentation" class="divider"></li>
434-
<li role="presentation"><a role="menuitem" href="#">Separated link</a></li>
434+
<li role="presentation"><a role="menuitem" tabindex="-1" href="#">Separated link</a></li>
435435
</ul>
436436
</li>
437437
</ul>
@@ -447,31 +447,31 @@ <h3>Within tabs</h3>
447447
<li class="dropdown">
448448
<a class="dropdown-toggle" id="drop4" role="button" data-toggle="dropdown" href="#">Dropdown <b class="caret"></b></a>
449449
<ul id="menu1" class="dropdown-menu" role="menu" aria-labelledby="drop4">
450-
<li role="presentation"><a role="menuitem" href="#">Action</a></li>
451-
<li role="presentation"><a role="menuitem" href="#">Another action</a></li>
452-
<li role="presentation"><a role="menuitem" href="#">Something else here</a></li>
450+
<li role="presentation"><a role="menuitem" tabindex="-1" href="#">Action</a></li>
451+
<li role="presentation"><a role="menuitem" tabindex="-1" href="#">Another action</a></li>
452+
<li role="presentation"><a role="menuitem" tabindex="-1" href="#">Something else here</a></li>
453453
<li role="presentation" class="divider"></li>
454-
<li role="presentation"><a role="menuitem" href="#">Separated link</a></li>
454+
<li role="presentation"><a role="menuitem" tabindex="-1" href="#">Separated link</a></li>
455455
</ul>
456456
</li>
457457
<li class="dropdown">
458458
<a class="dropdown-toggle" id="drop5" role="button" data-toggle="dropdown" href="#">Dropdown 2 <b class="caret"></b></a>
459459
<ul id="menu2" class="dropdown-menu" role="menu" aria-labelledby="drop5">
460-
<li role="presentation"><a role="menuitem" href="#">Action</a></li>
461-
<li role="presentation"><a role="menuitem" href="#">Another action</a></li>
462-
<li role="presentation"><a role="menuitem" href="#">Something else here</a></li>
460+
<li role="presentation"><a role="menuitem" tabindex="-1" href="#">Action</a></li>
461+
<li role="presentation"><a role="menuitem" tabindex="-1" href="#">Another action</a></li>
462+
<li role="presentation"><a role="menuitem" tabindex="-1" href="#">Something else here</a></li>
463463
<li role="presentation" class="divider"></li>
464-
<li role="presentation"><a role="menuitem" href="#">Separated link</a></li>
464+
<li role="presentation"><a role="menuitem" tabindex="-1" href="#">Separated link</a></li>
465465
</ul>
466466
</li>
467467
<li class="dropdown">
468468
<a class="dropdown-toggle" id="drop5" role="button" data-toggle="dropdown" href="#">Dropdown 3 <b class="caret"></b></a>
469469
<ul id="menu3" class="dropdown-menu" role="menu" aria-labelledby="drop5">
470-
<li role="presentation"><a role="menuitem" href="#">Action</a></li>
471-
<li role="presentation"><a role="menuitem" href="#">Another action</a></li>
472-
<li role="presentation"><a role="menuitem" href="#">Something else here</a></li>
470+
<li role="presentation"><a role="menuitem" tabindex="-1" href="#">Action</a></li>
471+
<li role="presentation"><a role="menuitem" tabindex="-1" href="#">Another action</a></li>
472+
<li role="presentation"><a role="menuitem" tabindex="-1" href="#">Something else here</a></li>
473473
<li role="presentation" class="divider"></li>
474-
<li role="presentation"><a role="menuitem" href="#">Separated link</a></li>
474+
<li role="presentation"><a role="menuitem" tabindex="-1" href="#">Separated link</a></li>
475475
</ul>
476476
</li>
477477
</ul> <!-- /tabs -->

0 commit comments

Comments
 (0)