Skip to content

Commit 088c727

Browse files
committed
data: reword storage key in dom
1 parent 5ad43fe commit 088c727

File tree

2 files changed

+15
-15
lines changed

2 files changed

+15
-15
lines changed

js/src/dom/data.js

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -16,37 +16,37 @@ const mapData = (() => {
1616
let id = 1
1717
return {
1818
set(element, key, data) {
19-
if (typeof element.key === 'undefined') {
20-
element.key = {
19+
if (typeof element.bsKey === 'undefined') {
20+
element.bsKey = {
2121
key,
2222
id
2323
}
2424
id++
2525
}
2626

27-
storeData[element.key.id] = data
27+
storeData[element.bsKey.id] = data
2828
},
2929
get(element, key) {
30-
if (!element || typeof element.key === 'undefined') {
30+
if (!element || typeof element.bsKey === 'undefined') {
3131
return null
3232
}
3333

34-
const keyProperties = element.key
34+
const keyProperties = element.bsKey
3535
if (keyProperties.key === key) {
3636
return storeData[keyProperties.id]
3737
}
3838

3939
return null
4040
},
4141
delete(element, key) {
42-
if (typeof element.key === 'undefined') {
42+
if (typeof element.bsKey === 'undefined') {
4343
return
4444
}
4545

46-
const keyProperties = element.key
46+
const keyProperties = element.bsKey
4747
if (keyProperties.key === key) {
4848
delete storeData[keyProperties.id]
49-
delete element.key
49+
delete element.bsKey
5050
}
5151
}
5252
}

js/tests/unit/dom/data.spec.js

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ describe('Data', () => {
1515
})
1616

1717
describe('setData', () => {
18-
it('should set data in an element by adding a key attribute', () => {
18+
it('should set data in an element by adding a bsKey attribute', () => {
1919
fixtureEl.innerHTML = '<div></div>'
2020

2121
const div = fixtureEl.querySelector('div')
@@ -24,7 +24,7 @@ describe('Data', () => {
2424
}
2525

2626
Data.setData(div, 'test', data)
27-
expect(div.key).toBeDefined()
27+
expect(div.bsKey).toBeDefined()
2828
})
2929

3030
it('should change data if something is already stored', () => {
@@ -40,7 +40,7 @@ describe('Data', () => {
4040
data.test = 'bsData2'
4141
Data.setData(div, 'test', data)
4242

43-
expect(div.key).toBeDefined()
43+
expect(div.bsKey).toBeDefined()
4444
})
4545
})
4646

@@ -104,11 +104,11 @@ describe('Data', () => {
104104

105105
Data.setData(div, 'test', data)
106106

107-
expect(div.key).toBeDefined()
107+
expect(div.bsKey).toBeDefined()
108108

109109
Data.removeData(div, 'test2')
110110

111-
expect(div.key).toBeDefined()
111+
expect(div.bsKey).toBeDefined()
112112
})
113113

114114
it('should remove data if something is stored', () => {
@@ -121,11 +121,11 @@ describe('Data', () => {
121121

122122
Data.setData(div, 'test', data)
123123

124-
expect(div.key).toBeDefined()
124+
expect(div.bsKey).toBeDefined()
125125

126126
Data.removeData(div, 'test')
127127

128-
expect(div.key).toBeUndefined()
128+
expect(div.bsKey).toBeUndefined()
129129
})
130130
})
131131
})

0 commit comments

Comments
 (0)