This repository has been archived by the owner on Feb 1, 2022. It is now read-only.
[v1] Warning if Bootstrap 3 classes are used #427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XhmikosR
reviewed
Oct 1, 2018
Johann-S
reviewed
Oct 17, 2018
Herst
force-pushed
the
next
branch
2 times, most recently
from
622ae8b
to
65d8daf
Compare
Herst
changed the title
Herst
force-pushed
the
next-bs3-check
branch
3 times, most recently
from
76147e0
to
f79eb02
Compare
Herst
force-pushed
the
next-bs3-check
branch
from
f79eb02
to
98ed7d1
Compare
Ports the following checks: - W009 (empty spacer column) - E005 (row and col on same element) - E012 (input-group and col on the same element) - E013 (invalid children of rows) - E014 (invalid parent of cols) - E029 (col 0 classes) - E037 (float classes and col) - E051 (float style and col) - E052 (float style and row)
|
Isn't this ready to be merged? |
|
Tests and wiki missing |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check for some Bootstrap 3 classes, at least those where I assume that are unlikely to be used for anything else, if they are detected then a new warning with the is id W018 is printed.
Status
For the wiki it would be nice to give some hints on what the Bootstrap 4 replacements for some of the things, see also #410 (comment)
/cc @XhmikosR @Johann-S