Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Usability) Prefixed releases with release-please are not processed with semver #35

Open
chrisvander opened this issue Jan 17, 2024 · 0 comments

Comments

@chrisvander
Copy link

chrisvander commented Jan 17, 2024

Hi,

I use a repository setup that involves releasing both a Helm chart and the app simultaneously. How release-please handles this is with a prefix. So I have tags of the style appname-v1.0.0-... and appname-helm-v1.0.0-.... I've changed the "match" to match appname-v[0-9]* but of course it does not filter the prefix before semver.parse(), which fails.

Could I have a way to either specify a group in the match to use (like appname-(v[0-9]*.*)) or some other method to match/filter a prefix?

A more general purpose solution could simply be an arbitrary format function that takes the tag and does something to it to make it semver compatible. I could do this on the other side, but I like the work you've put in to making the commit hash and number of commits to a semver-compatible format.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant