Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

False positives in Deficient Encapsulation design smell detection #57

Open
AntonisGkortzis opened this issue Jul 27, 2018 · 1 comment
Labels

Comments

@AntonisGkortzis
Copy link
Collaborator

This is caused due to counting the public fields of an inner class while the inner class is private.

When inner class is private her fields should not affect the Encapsulation Efficiency status of the outer class.

@AntonisGkortzis
Copy link
Collaborator Author

Temporarily fixed with the use of regex.

In case that nested types exist, each field of the outer type is parsed in order to check if this belongs to a nested class. When this is satisfied and the nested class is not public then the field is not accounted for the Deficient Encapsulation.

@AntonisGkortzis AntonisGkortzis removed their assignment Jul 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant