Update linter rules of turms-client-dart to v3 alternatives + Polish code

Author: JamesChenX

turms-client-dart/analysis_options.yaml

@@ -44,6 +44,7 @@ linter:
     - await_only_futures
     - camel_case_types
     - cascade_invocations
+    - collection_methods_unrelated_type
     - comment_references
     - constant_identifier_names
     - control_flow_in_finally
@@ -55,13 +56,10 @@ linter:
     - file_names
     - hash_and_equals
     - implementation_imports
-    - invariant_booleans
-    - iterable_contains_unrelated_type
     - join_return_with_assignment
     - library_names
     - library_prefixes
     - lines_longer_than_80_chars
-    - list_remove_unrelated_type
     - missing_whitespace_between_adjacent_strings
     - no_adjacent_strings_in_list
     - no_duplicate_case_values
@@ -80,7 +78,6 @@ linter:
     - prefer_const_constructors
     - prefer_const_declarations
     - prefer_contains
-    - prefer_equal_for_default_values
     - prefer_expression_function_bodies
     - prefer_final_fields
     - prefer_final_in_for_each

turms-client-dart/lib/src/driver/service/connection_service.dart

@@ -5,7 +5,6 @@ import 'dart:typed_data';
 import '../../exception/response_exception.dart';
 import '../../model/response_status_code.dart';
 import '../../transport/tcp_client.dart';
-import '../state_store.dart';
 import 'base_service.dart';
 
 typedef OnConnectedListener = void Function();
@@ -93,11 +92,10 @@ class ConnectionService extends BaseService {
   final _MessageDecoder _decoder = _MessageDecoder();
 
   ConnectionService(
-      StateStore stateStore, String? host, int? port, int? connectTimeoutMillis)
+      super.stateStore, String? host, int? port, int? connectTimeoutMillis)
       : _initialHost = host ?? '127.0.0.1',
         _initialPort = port ?? 11510,
-        _initialConnectTimeoutMillis = connectTimeoutMillis ?? 30 * 1000,
-        super(stateStore);
+        _initialConnectTimeoutMillis = connectTimeoutMillis ?? 30 * 1000;
 
   // Listeners
 

turms-client-dart/lib/src/driver/service/heartbeat_service.dart

@@ -4,7 +4,6 @@ import 'dart:math';
 import '../../exception/response_exception.dart';
 import '../../model/proto/notification/turms_notification.pb.dart';
 import '../../model/response_status_code.dart';
-import '../state_store.dart';
 import 'base_service.dart';
 
 class HeartbeatService extends BaseService {
@@ -18,15 +17,14 @@ class HeartbeatService extends BaseService {
   Timer? _heartbeatTimer;
   final List<Completer<void>> _heartbeatCompleters = [];
 
-  HeartbeatService(StateStore stateStore, int? heartbeatIntervalMillis)
+  HeartbeatService(super.stateStore, int? heartbeatIntervalMillis)
       : _heartbeatIntervalMillis =
             heartbeatIntervalMillis ?? _defaultHeartbeatIntervalMillis,
         _heartbeatTimerInterval = Duration(
             milliseconds: max(
                 1,
                 (heartbeatIntervalMillis ?? _defaultHeartbeatIntervalMillis) ~/
-                    10)),
-        super(stateStore);
+                    10));
 
   bool get isRunning => _heartbeatTimer?.isActive == true;
 

turms-client-dart/lib/src/driver/service/message_service.dart

@@ -6,7 +6,6 @@ import '../../extension/int_extensions.dart';
 import '../../model/proto/notification/turms_notification.pb.dart';
 import '../../model/proto/request/turms_request.pb.dart';
 import '../../model/response_status_code.dart';
-import '../state_store.dart';
 import 'base_service.dart';
 
 typedef NotificationListener = void Function(TurmsNotification notification);
@@ -28,9 +27,8 @@ class DriverMessageService extends BaseService {
   final List<NotificationListener> _notificationListeners = [];
   final Map<int, TurmsRequestContext> _idToRequest = {};
 
-  DriverMessageService(StateStore stateStore, int? requestTimeoutMillis,
-      int? minRequestIntervalMillis)
-      : super(stateStore) {
+  DriverMessageService(super.stateStore, int? requestTimeoutMillis,
+      int? minRequestIntervalMillis) {
     _requestTimeoutMillis =
         requestTimeoutMillis == null || requestTimeoutMillis <= 0
             ? 60 * 1000

turms-client-dart/lib/src/service/storage_service.dart

@@ -68,10 +68,11 @@ class StorageService {
   }
 
   Future<Response<Map<String, String>>> queryUserProfilePictureUploadInfo(
-      {String? name, String? mediaType, Map<String, String>? extra}) async {
-    return _queryResourceUploadInfo(StorageResourceType.USER_PROFILE_PICTURE,
-        name: name, mediaType: mediaType, extra: extra);
-  }
+          {String? name,
+          String? mediaType,
+          Map<String, String>? extra}) async =>
+      _queryResourceUploadInfo(StorageResourceType.USER_PROFILE_PICTURE,
+          name: name, mediaType: mediaType, extra: extra);
 
   Future<Response<Map<String, String>>> queryUserProfilePictureDownloadInfo(
       Int64 userId,
@@ -546,7 +547,7 @@ class StorageService {
       throw ResponseException(
           code: ResponseStatusCode.dataNotFound,
           reason:
-              'Could not get the resource URL because the key "$urlKeyName" does not exist in the data: ${data}');
+              'Could not get the resource URL because the key "$urlKeyName" does not exist in the data: $data');
     }
     return url;
   }