Skip to content

Conversation

@hmgaudecker
Copy link
Collaborator

What problem do you want to solve?

The way we implemented the loading of namespaces in #780 does not quite work.

We want to have them at the directory level to balance use of namespaces and reducing the amount of qualified names.

@codecov
Copy link

codecov bot commented Feb 22, 2025

Codecov Report

Attention: Patch coverage is 73.91304% with 6 lines in your changes missing coverage. Please review.

Please upload report for BASE (collect-components-of-namespaces@6c6c015). Learn more about missing BASE report.

Files with missing lines Patch % Lines
src/_gettsim/shared.py 62.50% 3 Missing ⚠️
src/_gettsim/functions/loader.py 80.00% 2 Missing ⚠️
src/_gettsim/interface.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@                         Coverage Diff                         @@
##             collect-components-of-namespaces     #818   +/-   ##
===================================================================
  Coverage                                    ?   48.52%           
===================================================================
  Files                                       ?       55           
  Lines                                       ?     4004           
  Branches                                    ?        0           
===================================================================
  Hits                                        ?     1943           
  Misses                                      ?     2061           
  Partials                                    ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator Author

@hmgaudecker hmgaudecker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update, makes perfect sense!

@hmgaudecker hmgaudecker merged commit e31e924 into collect-components-of-namespaces Feb 22, 2025
8 of 9 checks passed
@hmgaudecker hmgaudecker deleted the namespaces-at-dir-level branch February 22, 2025 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants