Add test case for base name with grouping in between.

MImmesberger · MImmesberger · commit d375f17d3b8a · 2025-04-10T12:32:45.000+02:00
diff --git a/src/ttsim/time_conversion.py b/src/ttsim/time_conversion.py
@@ -455,7 +455,7 @@ def _create_time_conversion_functions(
     )
 
     match = time_unit_pattern.fullmatch(name)
-    base_name = match.group("base_name") or ""
+    base_name = match.group("base_name")
     time_unit = match.group("time_unit") or ""
     aggregation = match.group("aggregation") or ""
 
diff --git a/tests/ttsim/test_shared.py b/tests/ttsim/test_shared.py
@@ -360,6 +360,7 @@ def test_potential_target_names_from_base_name(
         ("foo_m", ["m", "y"], ["hh"], "foo", "m", None),
         ("foo_y", ["m", "y"], ["hh"], "foo", "y", None),
         ("foo_hh", ["m", "y"], ["hh"], "foo", None, "hh"),
+        ("foo_hh_bar", ["m", "y"], ["hh"], "foo_hh_bar", None, None),
     ],
 )
 def test_get_re_pattern_for_time_units_and_groupings(

Original file line number	Diff line number	Diff line change
`@@ -455,7 +455,7 @@ def _create_time_conversion_functions(`
`455`	`455`	`)`
`456`	`456`
`457`	`457`	`match = time_unit_pattern.fullmatch(name)`
`458`		`- base_name = match.group("base_name") or ""`
	`458`	`+ base_name = match.group("base_name")`
`459`	`459`	`time_unit = match.group("time_unit") or ""`
`460`	`460`	`aggregation = match.group("aggregation") or ""`
`461`	`461`
Original file line number	Diff line number	Diff line change
`@@ -360,6 +360,7 @@ def test_potential_target_names_from_base_name(`
`360`	`360`	`("foo_m", ["m", "y"], ["hh"], "foo", "m", None),`
`361`	`361`	`("foo_y", ["m", "y"], ["hh"], "foo", "y", None),`
`362`	`362`	`("foo_hh", ["m", "y"], ["hh"], "foo", None, "hh"),`
	`363`	`+ ("foo_hh_bar", ["m", "y"], ["hh"], "foo_hh_bar", None, None),`
`363`	`364`	`],`
`364`	`365`	`)`
`365`	`366`	`def test_get_re_pattern_for_time_units_and_groupings(`