Skip to content

Commit 309f034

Browse files
committed
Update to latest Serilog.Settings.Configuration pre-release
To validate fix on assembly names for Serilog
1 parent d6e0752 commit 309f034

File tree

3 files changed

+26
-3
lines changed

3 files changed

+26
-3
lines changed

docs/README.md

+24-1
Original file line numberDiff line numberDiff line change
@@ -952,7 +952,30 @@ LoggerConfiguration
952952
```
953953

954954

955-
:warning: Inconstency : JSON provider seems to need fully-qualified type name for Serilog types, but appSettings does not ! [![GitHub issue state](https://img.shields.io/github/issues/detail/s/serilog/serilog-settings-configuration/81.svg)](https://github.com/serilog/serilog-settings-configuration/issues/81)
955+
- in **JSON** (ex : `331-ImplementationDefaultConstructor.json`)
956+
957+
```json
958+
{
959+
"Serilog": {
960+
"Using": [ "TestDummies" ],
961+
"WriteTo": [
962+
{
963+
"Name": "DummyWithFormatter",
964+
"Args": {
965+
"formatter": "Serilog.Formatting.Json.JsonFormatter"
966+
}
967+
},
968+
{
969+
"Name": "DummyConsole",
970+
"Args": {
971+
"theme": "TestDummies.Console.CustomConsoleTheme, TestDummies"
972+
}
973+
}
974+
]
975+
}
976+
}
977+
```
978+
956979

957980
- in **XML** (ex : `331-ImplementationDefaultConstructor.config`)
958981

test/Serilog.Settings.Comparison.Tests/3-Advanced settings formats/331_ImplementationDefaultConstructor.cs

+1-1
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ public ImplementationDefaultConstructor(ITestOutputHelper outputHelper)
1919

2020
[Theory]
2121
[InlineData("331-ImplementationDefaultConstructor.csx")]
22-
[InlineData("331-ImplementationDefaultConstructor.json", Skip = "Inconstency : JSON provider seems to need fully-qualified type name for Serilog types, but appSettings does not ! [![GitHub issue state](https://img.shields.io/github/issues/detail/s/serilog/serilog-settings-configuration/81.svg)](https://github.com/serilog/serilog-settings-configuration/issues/81)")]
22+
[InlineData("331-ImplementationDefaultConstructor.json")]
2323
[InlineData("331-ImplementationDefaultConstructor.config")]
2424
public void TestCase(string fileName)
2525
{

test/Serilog.Settings.Comparison.Tests/Serilog.Settings.Comparison.Tests.csproj

+1-1
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@
4444
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="15.9.0" />
4545
<PackageReference Include="Serilog" Version="2.7.2-dev-01017" />
4646
<PackageReference Include="Serilog.Filters.Expressions" Version="2.0.0" />
47-
<PackageReference Include="Serilog.Settings.Configuration" Version="3.0.1" />
47+
<PackageReference Include="Serilog.Settings.Configuration" Version="3.0.2-dev-00187" />
4848
<PackageReference Include="Serilog.Sinks.Async" Version="1.3.0" />
4949
<PackageReference Include="xunit" Version="2.4.1" />
5050
<PackageReference Include="xunit.runner.visualstudio" Version="2.4.1">

0 commit comments

Comments
 (0)