Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allows filtering inbox by accountId #474

Merged
merged 3 commits into from
Jul 24, 2023

Conversation

suhasdeshpande
Copy link
Contributor

Description

Allows specifying accountId in courier-provider

<CourierProvider
  clientKey="<your_client_key>"
  userId="<your_user_id>"
  accountId="<your_account_id>"
>
  <Inbox theme={theme} {...props} />
</CourierProvider>

This inbox will fetch and render all messages that were sent to user+accountId. If you don't specify accountId, your inbox will receive all messages sent to the user.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

@suhasdeshpande suhasdeshpande self-assigned this Jul 24, 2023
@suhasdeshpande suhasdeshpande added the enhancement New feature or request label Jul 24, 2023
drew-y
drew-y previously approved these changes Jul 24, 2023
@codecov
Copy link

codecov bot commented Jul 24, 2023

Codecov Report

❗ No coverage uploaded for pull request base (main@f96f6f6). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #474   +/-   ##
=======================================
  Coverage        ?   36.02%           
=======================================
  Files           ?       69           
  Lines           ?     1177           
  Branches        ?      353           
=======================================
  Hits            ?      424           
  Misses          ?      753           
  Partials        ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@suhasdeshpande suhasdeshpande merged commit f2e3bbe into main Jul 24, 2023
@suhasdeshpande suhasdeshpande deleted the suhas/allow-filter-by-account branch July 24, 2023 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

Successfully merging this pull request may close these issues.

4 participants