fix(pref-v4/list): fix hosted pref page flash on load. (prevent compo…

…nent from un-mounting)
trycourier · Jul 13, 2023 · cf61c67 · cf61c67
1 parent c7112c8
commit cf61c67
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 5 deletions.
diff --git a/packages/react-preferences/src/components/PreferenceList.tsx b/packages/react-preferences/src/components/PreferenceList.tsx
@@ -31,7 +31,7 @@ export const PreferenceList: React.FunctionComponent<{
   }, []);
 
   const renderPreferences = () => {
-    if (preferences?.isLoading) {
+    if (!preferences.preferencePage?.sections?.nodes.length) {
       return <></>;
     }
 

diff --git a/packages/react-preferences/src/components/PreferencesV4.tsx b/packages/react-preferences/src/components/PreferencesV4.tsx
@@ -436,10 +436,6 @@ export const PreferencesV4: React.FC<{ accountId?: string; draft?: boolean }> =
       pullPreferences();
     }, []);
 
-    if (preferences.isLoading || typeof preferences.isLoading === "undefined") {
-      return null;
-    }
-
     if (!preferences.preferencePage && !preferences.isLoading) {
       return (
         <div>