This repository has been archived by the owner on Jun 2, 2019. It is now read-only.
Add ENS names resolving / lookup #712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Black Duck Security ReportMerging #712 into master will not change security risk. Added ComponentsClean: 1 Removed ComponentsClean: 1 |
vikmeup
approved these changes
May 9, 2018
| guard data.count == 32 else { | ||
| return seal.reject(ENSError.decodeError) | ||
| } | ||
| let sub = Data(bytes: data.bytes[12...]) |
There was a problem hiding this comment.
take last 20 (32 - 12 ) bytes for Address, maybe data.suffix(20) is better?
There was a problem hiding this comment.
do you mind adding a comment that this is getting address, otherwise LGTM
vikmeup
approved these changes
May 10, 2018
vikmeup
approved these changes
May 12, 2018
| @@ -11,17 +11,20 @@ struct AccountViewModel { | |||
| let current: Wallet? | |||
| let walletBalance: Balance? | |||
| let server: RPCServer | |||
| let ensName: String | |||
There was a problem hiding this comment.
can we pas ENS Model instead?
There was a problem hiding this comment.
we can change this later, a string is enough right now
| @IBOutlet weak var balanceLable: UILabel! | ||
| @IBOutlet weak var addressLable: UILabel! |
There was a problem hiding this comment.
can you rename addressLabel ?
vikmeup
reviewed
May 12, 2018
| } | ||
| return "\(ensName) (\(wallet.address.description))" | ||
| return String(format: "%@ (%@...%@)", ensName, String(address.prefix(6)), String(address.suffix(6))) |
There was a problem hiding this comment.
do 4 or even 3, let's get this merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is essential for #311