-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: fix abtestui overlay #126
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kamilkifer
commented
May 20, 2024
fernicolosi
reviewed
May 21, 2024
fernicolosi
reviewed
May 21, 2024
fernicolosi
reviewed
May 21, 2024
fernicolosi
reviewed
May 21, 2024
fernicolosi
reviewed
Jun 3, 2024
fernicolosi
reviewed
Jun 4, 2024
fernicolosi
approved these changes
Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What⁉️
Why⁉️
How⁉️
npm link skift into wrapper
npm link wrapper into relevant app
slowly but surely, using the debugger.
The issue was that the app was running the shouldShowUI() call, before the user config was passed in.
currently handled by the configLoaded variable.
How to review and test 📱
Extra info
import type
Checklist ✅