Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: fix abtestui overlay #126

Merged
merged 18 commits into from
Jun 4, 2024
Merged

feat: fix abtestui overlay #126

merged 18 commits into from
Jun 4, 2024

Conversation

kamilkifer
Copy link
Contributor

@kamilkifer kamilkifer commented May 17, 2024


What ⁉️

  • fix the AB test ui.
    • problem caused by the app launching BEFORE the user config was loaded, leading to it being initialised with default config values.

Why ⁉️

  • To make it slightly easier to preview various variations of A/B tests.

How ⁉️

  • npm link skift into wrapper

  • npm link wrapper into relevant app

  • slowly but surely, using the debugger.

  • The issue was that the app was running the shouldShowUI() call, before the user config was passed in.

  • currently handled by the configLoaded variable.

How to review and test 📱

  • npm link as mentioned above.

Extra info

  • More problems spawned from the GHA
    • Initially, the linter was complaining, and the cause was import type
    • After some research, type-only imports were introduced in TS 3.8
  • Upgrading caused further compatibility problems.
  • I've updated a few packages, which causes other compatibility errors to appear, and lead to more package upgrades.
  • Eventually got it all working locally (via npm link), with tests passing and building properly.

Checklist ✅

  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing tests are passing locally

@kamilkifer kamilkifer closed this May 20, 2024
@kamilkifer kamilkifer reopened this May 20, 2024
tests/api.spec.ts Outdated Show resolved Hide resolved
src/ui.dev.ts Outdated Show resolved Hide resolved
src/main.ts Outdated Show resolved Hide resolved
src/main.ts Outdated Show resolved Hide resolved
src/ui.dev.ts Show resolved Hide resolved
tests/api.spec.ts Outdated Show resolved Hide resolved
tests/query.spec.ts Outdated Show resolved Hide resolved
@kamilkifer kamilkifer merged commit 1cf6169 into master Jun 4, 2024
1 check passed
@kamilkifer kamilkifer deleted the fix-abtestui branch June 4, 2024 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants