Skip to content

Commit

Permalink
feat: remove initialize from public API
Browse files Browse the repository at this point in the history
BREAKING CHANGE: initialize is no longer part of the public API because it was not documented, unlikely to be used and confusing.
  • Loading branch information
thomasthiebaud committed Jul 5, 2018
1 parent e977818 commit 6a55505
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 14 deletions.
3 changes: 0 additions & 3 deletions src/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ import {
getCurrentTestVariation,
getTest,
getUserAgentInfo,
initialize,
reset,
setCurrentTestVariation,
shouldShowUI,
Expand Down Expand Up @@ -47,7 +46,6 @@ export {
reset,
ui,
SplitTest,
initialize,
};

export default {
Expand All @@ -57,7 +55,6 @@ export default {
getCurrentTestVariation,
getTest,
getUserAgentInfo,
initialize,
reset,
setCurrentTestVariation,
tests,
Expand Down
11 changes: 0 additions & 11 deletions tests/config.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -20,15 +20,4 @@ describe('Config', () => {
expect(config).toBeDefined();
expect(config.cookieName).toEqual('Test');
});

it('should keep configuration after multiple initialization', () => {
skift.config({
cookieName: 'Test',
});

skift.initialize();
skift.initialize();
expect(config).toBeDefined();
expect(config.cookieName).toEqual('Test');
});
});

0 comments on commit 6a55505

Please sign in to comment.