fix: linting

trustpilot · Sep 3, 2020 · 4269867 · 4269867
1 parent d55e76e
commit 4269867
Show file tree

Hide file tree

Showing 6 changed files with 53 additions and 45 deletions.
diff --git a/src/config.ts b/src/config.ts
@@ -1,7 +1,8 @@
 import { Condition } from './condition';
+import { CookiePersister } from './cookiePersister';
 import { removeAbTestParameter } from './query';
 import { ConsoleTracking, Tracking } from './tracking';
-import { CookiePersister, UserSessionPersister } from './userSessionPersister';
+import { UserSessionPersister } from './userSessionPersister';
 
 export interface Config {
     cookieName: string;

diff --git a/src/cookiePersister.ts b/src/cookiePersister.ts
@@ -0,0 +1,33 @@
+import config from './config';
+import { UserSessionPersister } from './userSessionPersister';
+
+export class CookiePersister implements UserSessionPersister {
+  private static createCookie(name: string, value: string, days: number): void {
+      let expires = '';
+      if (days) {
+          const date = new Date();
+          date.setTime(date.getTime() + (days * 24 * 60 * 60 * 1000));
+          expires = '; expires=' + date.toUTCString();
+      }
+      document.cookie = name + '=' + value + expires + '; path=/';
+  }
+  private static readCookie(name: string): string | null {
+      const nameEq = name + '=';
+      const ca = document.cookie.split(';');
+      for (let c of ca) {
+          while (c.charAt(0) === ' ') {
+              c = c.substring(1, c.length);
+          }
+          if (c.indexOf(nameEq) === 0) {
+              return c.substring(nameEq.length, c.length);
+          }
+      }
+      return null;
+  }
+  public loadUserSession() {
+      return CookiePersister.readCookie(config.cookieName);
+  }
+  public saveUserSession(userSession: string, daysToLive: number) {
+      CookiePersister.createCookie(config.cookieName, userSession, daysToLive);
+  }
+}
diff --git a/src/inMemoryPersister.ts b/src/inMemoryPersister.ts
@@ -0,0 +1,13 @@
+import { UserSessionPersister } from './userSessionPersister';
+
+export class InMemoryPersister implements UserSessionPersister {
+  private endOfLife: number = 0;
+  private storage: string = '';
+  public loadUserSession() {
+      return !this.endOfLife || (Date.now() > this.endOfLife) ? '' : this.storage;
+  }
+  public saveUserSession(userSession: string, daysToLive: number) {
+      this.storage = userSession;
+      this.endOfLife = Date.now() + (daysToLive * 24 * 60 * 60 * 1000);
+  }
+}
diff --git a/src/index.ts b/src/index.ts
@@ -1,3 +1,5 @@
+import { CookiePersister } from './cookiePersister';
+import { InMemoryPersister } from './inMemoryPersister';
 import {
     config,
     create,
@@ -12,7 +14,7 @@ import {
 } from './main';
 import { SplitTest } from './splitTest';
 import { uiFactory } from './ui';
-import { UserSessionPersister, InMemoryPersister, CookiePersister } from './userSessionPersister';
+import { UserSessionPersister } from './userSessionPersister';
 
 const ui = uiFactory(
     testsObservable,

diff --git a/src/main.ts b/src/main.ts
@@ -31,9 +31,9 @@ export function config(userConfig: Partial<Config> = {}) {
         _config.onVariationChange = userConfig.onVariationChange;
     }
     if (userConfig.sessionPersister) {
-        const userSession = _config.sessionPersister.loadUserSession() || '';
+        const session = _config.sessionPersister.loadUserSession() || '';
         _config.sessionPersister = userConfig.sessionPersister;
-        _config.sessionPersister.saveUserSession(userSession, _config.userSessionDaysToLive);
+        _config.sessionPersister.saveUserSession(session, _config.userSessionDaysToLive);
     }
 }
 

diff --git a/src/userSessionPersister.ts b/src/userSessionPersister.ts
@@ -3,44 +3,3 @@ export interface UserSessionPersister {
     loadUserSession(): string | null;
     saveUserSession(userSession: string, daysToLive: number): void;
 }
-export class CookiePersister implements UserSessionPersister {
-    public loadUserSession() {
-        return CookiePersister.readCookie(config.cookieName);
-    }
-    public saveUserSession(userSession: string, daysToLive: number) {
-        CookiePersister.createCookie(config.cookieName, userSession, daysToLive);
-    }
-    private static createCookie(name: string, value: string, days: number): void {
-        let expires = '';
-        if (days) {
-            const date = new Date();
-            date.setTime(date.getTime() + (days * 24 * 60 * 60 * 1000));
-            expires = '; expires=' + date.toUTCString();
-        }
-        document.cookie = name + '=' + value + expires + '; path=/';
-    }
-    private static readCookie(name: string): string | null {
-        const nameEq = name + '=';
-        const ca = document.cookie.split(';');
-        for (let c of ca) {
-            while (c.charAt(0) === ' ') {
-                c = c.substring(1, c.length);
-            }
-            if (c.indexOf(nameEq) === 0) {
-                return c.substring(nameEq.length, c.length);
-            }
-        }
-        return null;
-    }
-}
-export class InMemoryPersister implements UserSessionPersister {
-    private endOfLife: number = 0;
-    private storage: string = '';
-    public loadUserSession() {
-        return !this.endOfLife || (Date.now() > this.endOfLife) ? '' : this.storage;
-    }
-    public saveUserSession(userSession: string, daysToLive: number) {
-        this.storage = userSession;
-        this.endOfLife = Date.now() + (daysToLive*24*60*60*1000);
-    }
-}