Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Class or namespace should be renamed #11

Closed
fagnercarvalho opened this issue Aug 6, 2019 · 5 comments · Fixed by #12
Closed

Class or namespace should be renamed #11

fagnercarvalho opened this issue Aug 6, 2019 · 5 comments · Fixed by #12

Comments

@fagnercarvalho
Copy link

I don't believe that keeping the class and namespace the same (AuthenticatedEncryption) is a good idea.

How about we refactor this?

Some references:

@dandago
Copy link

dandago commented Nov 2, 2019

I agree, I have to use AuthenticatedEncryption.AuthenticatedEncryption.Encrypt(...) every time.

@refactorsaurusrex
Copy link
Contributor

Hey @spewu, would you accept a PR if I make these changes? I could fork and create a separate nuget package, but I'd rather not do that just for a namespace change. Thanks in advance!

@spewu
Copy link
Contributor

spewu commented Jun 5, 2020

@refactorsaurusrex Thanks for mentioning me here - I had not seen this issue. I no longer work in Trustpilot, but I am pretty confident that I can get your PR merged if you create one

@refactorsaurusrex
Copy link
Contributor

Great! I'll get on that soon.

@irq
Copy link
Contributor

irq commented Jun 11, 2020

The package has now been updated thanks to @refactorsaurusrex 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants