-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/publish old image #25
Open
samcorzineatfetch
wants to merge
35
commits into
trustpilot:master
Choose a base branch
from
fetch-rewards:feature/publish-old-image
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Feature/publish old image #25
samcorzineatfetch
wants to merge
35
commits into
trustpilot:master
from
fetch-rewards:feature/publish-old-image
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…add a getter for the new field
…oviding credentions for the session
Add assumed role arn
removed hardcode
updated test-cases and jar filename as per build
Remove table hardcode - updated testcases and gradle build jar filename
Un marshall dynamo documents
updating format to JSON before pushing records to kafka and updated test cases
…JSON updating format to JSON before pushing records to kafka
…JSON Converting dyanmo documents to json before pushing to kafka
…JSON updated to send unmarshalled record with schema to kafka topic
…h-rewards/kafka-connect-dynamodb into unMarshall-Dynamo-Documents
Un marshall dynamo documents
Feature/init sync
…fset handle no offset init.sync.skip
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket 🎟
What⁉️
Adding support to publish the old image in dynamo streams that have both new and old images. This enables more complex flows for Dynamo CDC.
New field has been added to the payload named "old_document" which will be null if that field isn't there. This should be a backwards compatible change since no other fields have been modified.
Why⁉️
This enables easy diffing of fields that have been modified.
How⁉️
Added the field, tested changes manually on a dev cluster to verify behavior
How to review and test 📱
tbd
Checklist ✅