chore(all-contributors): add gidjin as a contributor for maintenance #2436
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allcontributors
bot
requested review from
SirenaBorracha,
ahobson,
brandonlenz,
gidjin and
haworku
as code owners
brandonlenz
removed request for
a user,
SirenaBorracha,
ahobson,
brandonlenz,
haworku,
jcbcapps and
rogeruiz
Contributor
|
@gidjin You've been maintainer for a good while now. If you want to be recognized for that work by all contributors, please feel free to merge this PR 😄 |
brandonlenz
changed the title
brandonlenz
reviewed
Jun 6, 2023
| "contributorsPerLine": 7, | ||
| "commitConvention": "angular" | ||
| "commitConvention": "angular", | ||
| "commitType": "chore(all-contributors)" |
Contributor
There was a problem hiding this comment.
Updated this from default of docs (all contributors added in this commit: feaa676).
This is a new/undocumented property. Opened an issue with all-contributors to get some clarity on how to use it.
Contributor
There was a problem hiding this comment.
We don't want these in our CHANGELOG.md, so let's use chore instead of docs
gidjin
approved these changes
Jun 16, 2023
Contributor
gidjin
left a comment
gidjin
left a comment
There was a problem hiding this comment.
LGTM! Thanks @brandonlenz
gidjin
approved these changes
Jun 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds @gidjin as a contributor for maintenance.
This was requested by brandonlenz in this comment