This repository was archived by the owner on Mar 11, 2024. It is now read-only.
Declare network option in launch configuration
#267
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acuarica
added
enhancement
kevinbluer
reviewed
Dec 1, 2022
package.json
Outdated
| }, | ||
| { | ||
| "label": "Truffle - Debugger Launch using config network", | ||
| "description": "Runs the Truffle debugger (truffle) and attaches to a TestRPC instance", |
Contributor
There was a problem hiding this comment.
Super minor thing but just wondering if we should call it a "Ganache" instance vs "TestRPC" (given the latter is super dated)
Contributor
Author
There was a problem hiding this comment.
Thanks @kevinbluer for catching this. I've changed it to Ganache. Before I used TestRPC because it was used in a similar snippet, so I changed both.
kevinbluer
approved these changes
Dec 1, 2022
Contributor
kevinbluer
left a comment
kevinbluer
left a comment
There was a problem hiding this comment.
Also approving as other than that (optional) minor comment it's good to go from my side.
1 task
alexandratran
removed
the
doc-change-required
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
This PR declares the newly added
networkoption #261 in the launch configuration.truffle-test-debug-1669291480307.mp4
Moreover, it includes a new configuration snippet that uses the
networkoption instead ofproviderUrltruffle-test-debug-1669292644960.mp4
Documentation
doc-change-requiredlabel to this PR if documentation updates are required.