Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

S3 Secret Keys not detected #3381

Open
iFrozenPhoenix opened this issue Oct 7, 2024 · 4 comments
Open

S3 Secret Keys not detected #3381

iFrozenPhoenix opened this issue Oct 7, 2024 · 4 comments
Labels

Comments

@iFrozenPhoenix
Copy link

Version

3.82.6

Trace Output

NOT APPLICABLE

Expected Behavior

S3 Secret Keys that are defined in a JSON file as a KV pair S3_SECRET_KEY: verysecret are recognized. The corresponding S3_ACCESS_KEY pairs are recognized.

Actual Behavior

S3 access keys are recognized, S3 secret keys not.

Steps to Reproduce

  1. Take a test JSON file with both KV pairs
  2. Place the JSON in a S3 Bucket
  3. Scan the bucket (without any special flags)
  4. See that S3_ACCESS_KEY is recognized and S3_SECRET_KEY not

Environment

  • OS: debian
  • Version testing (Rolling)

Additional Context

{
  "env": {
    "S3_ACCESS_KEY": "i-have-an-access-key",
    "S3_SECRET_KEY": "and-a-secret-key"
  }
}

References

  • #0000
@dustin-decker
Copy link
Contributor

Are you expecting the sample that you provided to be detected? That wouldn't match the pattern required.

@iFrozenPhoenix
Copy link
Author

iFrozenPhoenix commented Oct 7, 2024

Yes indeed I expect it to be detected. The access key is detected in such a file, but the secret key not.
Can't understand the reason behind it.

@dustin-decker
Copy link
Contributor

Are you trying to detect actual keys? Or placeholders like you provided?

@iFrozenPhoenix
Copy link
Author

iFrozenPhoenix commented Oct 7, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

2 participants