Skip to content

[common] Move Traefik CRs to Common #28999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
2 tasks done
PrivatePuffin opened this issue Nov 8, 2024 · 1 comment · Fixed by #31498
Closed
2 tasks done

[common] Move Traefik CRs to Common #28999

PrivatePuffin opened this issue Nov 8, 2024 · 1 comment · Fixed by #31498
Labels
enhancement New feature or request

Comments

@PrivatePuffin
Copy link
Member

Is your feature request related to a problem?

Currently only the Traefik chart can spawn CRs, such as middlewares.
How-ever, in practice we would want all CRs in common, for standardization and to prevent repeat code.

Having them in Traefik has come to haunt us a few times when we updated templating standards and forgot we had custom CRs defined in Traefik.

Describe the solution you'd like

We should instead move the CR rendering to common, which allows us to implement more common-templating on them. But also allow all apps to spawn them.

Describe alternatives you've considered

Keep things as-is

Additional context

No response

I've read and agree with the following

  • I've checked all open and closed issues and my request is not there.
  • I've checked all open and closed pull requests and my request is not there.
@truecharts-admin
Copy link
Collaborator

This issue is locked to prevent necro-posting on closed issues. Please create a new issue or contact staff on discord of the problem persists

@truecharts truecharts locked and limited conversation to collaborators Feb 9, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants